Address review feedback

Author: venkateshwaracholan

persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java

@@ -811,9 +811,8 @@ Optional<Optional<String>> hasOverlappingSiblings(
       if (!results.isEmpty()) {
         StorageLocation entityLocation = StorageLocation.of(entity.getBaseLocation());
         for (PolarisBaseEntity result : results) {
-          // JDBC materializes persisted rows as PolarisBaseEntity; resolve location via entity
-          // utils
-          // instead of casting to LocationBasedEntity.
+          // JDBC materializes persisted rows as PolarisBaseEntity. Resolve the sibling location
+          // via PolarisEntityUtils instead of casting to LocationBasedEntity.
           Optional<String> overlappingSiblingLocation =
               PolarisEntityUtils.asLocationBasedEntity(PolarisEntity.of(result))
                   .map(LocationBasedEntity::getBaseLocation)

persistence/relational-jdbc/src/test/java/org/apache/polaris/persistence/relational/jdbc/AtomicMetastoreManagerWithJdbcBasePersistenceImplTest.java

@@ -40,6 +40,7 @@
 import org.apache.polaris.core.persistence.BasePolarisMetaStoreManagerTest;
 import org.apache.polaris.core.persistence.PolarisTestMetaStoreManager;
 import org.assertj.core.api.Assertions;
+import org.assertj.core.api.Assumptions;
 import org.h2.jdbcx.JdbcConnectionPool;
 import org.junit.jupiter.api.Test;
 import org.mockito.Mockito;
@@ -92,9 +93,7 @@ protected PolarisTestMetaStoreManager createPolarisTestMetaStoreManager() {
   @Test
   void testHasOverlappingSiblingsUsesStoredBaseLocation() {
     // The optimized check relies on the location_without_scheme column added in schema v2.
-    if (schemaVersion() < 2) {
-      return;
-    }
+    Assumptions.assumeThat(schemaVersion()).isGreaterThanOrEqualTo(2);
 
     var metaStoreManager = polarisTestMetaStoreManager.polarisMetaStoreManager();
     var callContext = polarisTestMetaStoreManager.polarisCallContext();