pass by value + std::move for better performance

Author: BewareMyPower

include/pulsar/Client.h

@@ -429,7 +429,7 @@ class PULSAR_PUBLIC Client {
      *
      * @param serviceInfo the service URL, authentication and TLS trust certs file path to use
      */
-    void updateServiceInfo(const ServiceInfo& serviceInfo);
+    void updateServiceInfo(ServiceInfo serviceInfo);
 
     /**
      * Get the current service information of the client.

lib/Client.cc

@@ -198,7 +198,7 @@ void Client::getSchemaInfoAsync(const std::string& topic, int64_t version,
         .addListener(std::move(callback));
 }
 
-void Client::updateServiceInfo(const ServiceInfo& serviceInfo) { impl_->updateServiceInfo(serviceInfo); }
+void Client::updateServiceInfo(ServiceInfo serviceInfo) { impl_->updateServiceInfo(std::move(serviceInfo)); }
 
 ServiceInfo Client::getServiceInfo() const { return impl_->getServiceInfo(); }
 

lib/ClientImpl.cc

@@ -880,7 +880,7 @@ std::chrono::nanoseconds ClientImpl::getOperationTimeout(const ClientConfigurati
     return clientConfiguration.impl_->operationTimeout;
 }
 
-void ClientImpl::updateServiceInfo(const ServiceInfo& serviceInfo) {
+void ClientImpl::updateServiceInfo(ServiceInfo&& serviceInfo) {
     std::unique_lock lock(mutex_);
     if (state_ != Open) {
         LOG_ERROR("Client is not open, cannot update connection info");

lib/ClientImpl.h

@@ -140,7 +140,7 @@ class ClientImpl : public std::enable_shared_from_this<ClientImpl> {
     ConnectionPool& getConnectionPool() noexcept { return pool_; }
     uint64_t getLookupCount() { return lookupCount_; }
 
-    void updateServiceInfo(const ServiceInfo& serviceInfo);
+    void updateServiceInfo(ServiceInfo&& serviceInfo);
     ServiceInfo getServiceInfo() const;
 
     static std::chrono::nanoseconds getOperationTimeout(const ClientConfiguration& clientConfiguration);