Skip to content

Commit 4a86cf9

Browse files
committed
address comments
1 parent 29d28e7 commit 4a86cf9

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

lib/ConsumerImpl.cc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1656,10 +1656,8 @@ void ConsumerImpl::hasMessageAvailableAsync(const HasMessageAvailableCallback& c
16561656
// doesn't have other ids such as batch index
16571657
auto compareResult = compareLedgerAndEntryId(response.getMarkDeletePosition(),
16581658
response.getLastMessageId());
1659-
// When the consumer has sought by timestamp that is later than the last message, the
1660-
// mark-delete position will still be the same with the last message id's position. But
1661-
// broker won't dispatch messages even if startMessageId is inclusive, so we should return
1662-
// false in this case.
1659+
// When the consumer has sought by timestamp, broker will ignore the
1660+
// startMessageIdInclusive config, so the compare should still be exclusive
16631661
if (lastSeekIsByTimestamp || !self->config_.isStartMessageIdInclusive()) {
16641662
callback(ResultOk, compareResult < 0);
16651663
} else {

0 commit comments

Comments
 (0)