fix windows build

Author: BewareMyPower

LegacyFindPackages.cmake

@@ -95,8 +95,13 @@ message("OPENSSL_INCLUDE_DIR: " ${OPENSSL_INCLUDE_DIR})
 message("OPENSSL_LIBRARIES: " ${OPENSSL_LIBRARIES})
 
 if (LATEST_PROTOBUF)
-    # See https://github.com/apache/arrow/issues/35987
-    add_definitions(-DPROTOBUF_USE_DLLS)
+    if (NOT LINK_STATIC)
+        # Only needed when protobuf itself is a DLL; static builds must NOT define this
+        # because it marks symbols as __declspec(dllimport), causing LNK2019 when
+        # linking against a static libprotobuf.lib.
+        # See https://github.com/apache/arrow/issues/35987
+        add_definitions(-DPROTOBUF_USE_DLLS)
+    endif ()
     # Use Config mode to avoid FindProtobuf.cmake does not find the Abseil library
     find_package(Protobuf REQUIRED CONFIG)
 else ()
@@ -278,8 +283,8 @@ if (MSVC)
         wldap32.lib
         Normaliz.lib)
     if (LINK_STATIC)
-        # add external dependencies of libcurl
-        set(COMMON_LIBS ${COMMON_LIBS} ws2_32.lib crypt32.lib)
+        # add external dependencies of libcurl (iphlpapi for if_nametoindex)
+        set(COMMON_LIBS ${COMMON_LIBS} ws2_32.lib crypt32.lib iphlpapi.lib)
         # the default compile options have /MD, which cannot be used to build DLLs that link static libraries
         string(REGEX REPLACE "/MD" "/MT" CMAKE_CXX_FLAGS_DEBUG ${CMAKE_CXX_FLAGS_DEBUG})
         string(REGEX REPLACE "/MD" "/MT" CMAKE_CXX_FLAGS_RELEASE ${CMAKE_CXX_FLAGS_RELEASE})

lib/CMakeLists.txt

@@ -145,7 +145,21 @@ if (LINK_STATIC AND BUILD_STATIC_LIB)
         else ()
             remove_libtype("${COMMON_LIBS}" "debug" STATIC_LIBS)
         endif ()
-        set_property(TARGET pulsarStaticWithDeps PROPERTY STATIC_LIBRARY_OPTIONS ${STATIC_LIBS})
+        # lib.exe (STATIC_LIBRARY_OPTIONS) cannot resolve CMake imported target names.
+        # Replace each CMake target with $<TARGET_FILE:...>; keep only static archives
+        # (skip system import libs that have no absolute path and non-archive targets).
+        set(RESOLVED_STATIC_LIBS "")
+        foreach (LIB IN LISTS STATIC_LIBS)
+            if (TARGET ${LIB})
+                get_target_property(_LIB_TYPE ${LIB} TYPE)
+                if (_LIB_TYPE STREQUAL "STATIC_LIBRARY" OR _LIB_TYPE STREQUAL "UNKNOWN_LIBRARY")
+                    list(APPEND RESOLVED_STATIC_LIBS "$<TARGET_FILE:${LIB}>")
+                endif ()
+            elseif (IS_ABSOLUTE "${LIB}" AND LIB MATCHES "\\.(lib|a)$")
+                list(APPEND RESOLVED_STATIC_LIBS "${LIB}")
+            endif ()
+        endforeach ()
+        set_property(TARGET pulsarStaticWithDeps PROPERTY STATIC_LIBRARY_OPTIONS ${RESOLVED_STATIC_LIBS})
         set_property(TARGET pulsarStaticWithDeps PROPERTY OUTPUT_NAME ${LIB_NAME}WithDeps)
         set_property(TARGET pulsarStaticWithDeps PROPERTY VERSION ${LIBRARY_VERSION})
         install(TARGETS pulsarStaticWithDeps DESTINATION lib)