-
Notifications
You must be signed in to change notification settings - Fork 86
PIP-121: Implement AutoClusterFailover #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
BewareMyPower
merged 13 commits into
apache:main
from
BewareMyPower:bewaremypower/auto-cluster-failover
Mar 17, 2026
Merged
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5df139c
PIP-121: Implement AutoClusterFailover
BewareMyPower d15a822
fix tidy errors
BewareMyPower f56ac5c
fix format
BewareMyPower 8a0d644
address some comments
BewareMyPower 2664b93
fix incorrect thread model
BewareMyPower 4cfd0d3
avoid copy on original service infos in config
BewareMyPower 13dbf89
fix lifetime of probeHostsAsync
BewareMyPower 88bacdb
remove unnecessary logs
BewareMyPower afc659f
replace the delay-based configs with count-based configs
BewareMyPower fb0cb42
reduce the default check interval
BewareMyPower aa93505
fix failed tests
BewareMyPower bf5edbe
address some comments
BewareMyPower 997c985
fix secondary list are not respected
BewareMyPower File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| #ifndef PULSAR_AUTO_CLUSTER_FAILOVER_H_ | ||
| #define PULSAR_AUTO_CLUSTER_FAILOVER_H_ | ||
|
|
||
| #include <pulsar/ServiceInfoProvider.h> | ||
|
|
||
| #include <chrono> | ||
|
|
||
| namespace pulsar { | ||
|
|
||
| class Client; | ||
| class AutoClusterFailoverImpl; | ||
|
|
||
| class PULSAR_PUBLIC AutoClusterFailover final : public ServiceInfoProvider { | ||
| public: | ||
| struct Config { | ||
| ServiceInfo primary; | ||
| std::vector<ServiceInfo> secondary; | ||
| std::chrono::milliseconds checkInterval{30000}; // 30 seconds | ||
| std::chrono::milliseconds failoverDelay{30000}; // 30 seconds | ||
| std::chrono::milliseconds switchBackDelay{60000}; // 60 seconds | ||
| }; | ||
|
|
||
| /** | ||
| * Builder helps create an AutoClusterFailover configuration. | ||
| * | ||
| * Example: | ||
| * ServiceInfo primary{...}; | ||
| * std::vector<ServiceInfo> secondaries{...}; | ||
| * AutoClusterFailover provider = AutoClusterFailover::Builder(primary, secondaries) | ||
| * .withCheckInterval(std::chrono::seconds(30)) | ||
| * .withFailoverDelay(std::chrono::seconds(30)) | ||
| * .withSwitchBackDelay(std::chrono::seconds(60)) | ||
| * .build(); | ||
| * | ||
| * Notes: | ||
| * - primary: the preferred cluster to use when available. | ||
| * - secondary: ordered list of fallback clusters. | ||
| * - checkInterval: frequency of health probes. | ||
| * - failoverDelay: how long the current cluster must be unreachable before switching. | ||
| * - switchBackDelay: how long the primary must remain healthy before switching back. | ||
| */ | ||
| class Builder { | ||
| public: | ||
| Builder(ServiceInfo primary, std::vector<ServiceInfo> secondary) { | ||
| config_.primary = std::move(primary); | ||
| config_.secondary = std::move(secondary); | ||
| } | ||
|
|
||
| // Set how frequently probes run against the active cluster(s). | ||
| Builder& withCheckInterval(std::chrono::milliseconds interval) { | ||
| config_.checkInterval = interval; | ||
| return *this; | ||
| } | ||
|
|
||
| // Set how long the current cluster must be unreachable before attempting failover. | ||
| Builder& withFailoverDelay(std::chrono::milliseconds delay) { | ||
| config_.failoverDelay = delay; | ||
| return *this; | ||
| } | ||
|
|
||
| // Set how long the primary must remain healthy before switching back from a secondary. | ||
| Builder& withSwitchBackDelay(std::chrono::milliseconds delay) { | ||
| config_.switchBackDelay = delay; | ||
| return *this; | ||
| } | ||
|
|
||
| AutoClusterFailover build() { return AutoClusterFailover(std::move(config_)); } | ||
|
|
||
| private: | ||
| Config config_; | ||
| }; | ||
|
|
||
| explicit AutoClusterFailover(Config&& config); | ||
|
|
||
| ~AutoClusterFailover() final; | ||
|
|
||
| ServiceInfo initialServiceInfo() final; | ||
|
|
||
| void initialize(std::function<void(ServiceInfo)> onServiceInfoUpdate) final; | ||
|
|
||
| private: | ||
| std::shared_ptr<AutoClusterFailoverImpl> impl_; | ||
| }; | ||
|
|
||
| } // namespace pulsar | ||
|
|
||
| #endif | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.