Skip to content

PIP-254: Support configuring client version#1316

Merged
nodece merged 13 commits into
apache:masterfrom
crossoverJie:pip-254
Dec 13, 2024
Merged

PIP-254: Support configuring client version#1316
nodece merged 13 commits into
apache:masterfrom
crossoverJie:pip-254

Conversation

@crossoverJie
Copy link
Copy Markdown
Member

Modifications

Reference Java client.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Comment thread pulsar/client_impl_test.go Outdated
Comment thread pulsar/client_impl_test.go
Comment thread pulsar/client_impl_test.go Outdated
Comment thread pulsar/consumer_test.go Outdated
Comment thread pulsar/consumer_test.go Outdated
crossoverJie and others added 5 commits December 13, 2024 13:51
Co-authored-by: Zixuan Liu <nodeces@gmail.com>
Co-authored-by: Zixuan Liu <nodeces@gmail.com>
Co-authored-by: Zixuan Liu <nodeces@gmail.com>
Co-authored-by: Zixuan Liu <nodeces@gmail.com>
Co-authored-by: Zixuan Liu <nodeces@gmail.com>
@crossoverJie crossoverJie requested a review from nodece December 13, 2024 10:06
@nodece nodece merged commit 0612938 into apache:master Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants