fix: add bounds check for partition index int32 conversion#1517
Open
merlimat wants to merge 1 commit into
Open
fix: add bounds check for partition index int32 conversion#1517merlimat wants to merge 1 commit into
merlimat wants to merge 1 commit into
Conversation
CodeQL go/incorrect-integer-conversion (CWE-190/CWE-681) flagged the int->int32 conversion of the topic-derived partition index in newPartitionConsumer. Guard it with an explicit int32 range check; negative values (-1 for non-partitioned topics) remain valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CodeQL code-scanning alert #1 (
go/incorrect-integer-conversion, high — CWE-190 / CWE-681) flagspulsar/consumer_partition.go:422, where the partition index — ultimately parsed from the topic name viastrconv.AtoiingetPartitionIndex— is converted frominttoint32without a bounds check.Modifications
Add an explicit range check in
newPartitionConsumerbefore theint32(options.partitionIdx)conversion, returning an error if the value falls outside theint32range. Negative values (e.g.-1for non-partitioned topics) remain valid.Verifying this change
This change is a trivial rework without new test coverage; the conversion is exercised by the existing partitioned-consumer tests.
Does this pull request potentially affect one of the following parts:
Documentation