Skip to content

Commit 1f5a7f3

Browse files
committed
improve tests
1 parent dd594b7 commit 1f5a7f3

1 file changed

Lines changed: 5 additions & 14 deletions

File tree

tests/asyncio_test.py

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -469,13 +469,17 @@ async def test_seek_timestamp(self):
469469
async def test_reader_simple(self):
470470
topic = f'asyncio-test-reader-simple-{time.time()}'
471471
reader = await self._client.create_reader(topic, pulsar.MessageId.earliest)
472+
self.assertTrue(reader.is_connected())
473+
self.assertEqual(reader.topic(), f'persistent://public/default/{topic}')
474+
472475
producer = await self._client.create_producer(topic)
473476
await producer.send(b'hello')
474477
msg = await reader.read_next()
475478
self.assertEqual(msg.data(), b'hello')
476479
with self.assertRaises(asyncio.TimeoutError):
477480
await asyncio.wait_for(reader.read_next(), 1)
478481
await reader.close()
482+
self.assertFalse(reader.is_connected())
479483

480484
async def test_reader_on_last_message(self):
481485
topic = f'asyncio-test-reader-on-last-message-{time.time()}'
@@ -516,8 +520,8 @@ async def test_reader_has_message_available(self):
516520
self.assertFalse(await reader.has_message_available())
517521
for i in range(10):
518522
await producer.send(f'hello-{i}'.encode())
519-
self.assertTrue(await reader.has_message_available())
520523
for _ in range(10):
524+
self.assertTrue(await reader.has_message_available())
521525
await reader.read_next()
522526
self.assertFalse(await reader.has_message_available())
523527
await reader.close()
@@ -542,19 +546,6 @@ async def test_reader_seek(self):
542546
self.assertEqual(msg.data(), b'msg-2')
543547
await reader_inclusive.close()
544548

545-
async def test_reader_is_connected(self):
546-
topic = f'asyncio-test-reader-is-connected-{time.time()}'
547-
reader = await self._client.create_reader(topic, pulsar.MessageId.earliest)
548-
self.assertTrue(reader.is_connected())
549-
await reader.close()
550-
self.assertFalse(reader.is_connected())
551-
552-
async def test_reader_topic(self):
553-
topic = f'asyncio-test-reader-topic-{time.time()}'
554-
reader = await self._client.create_reader(topic, pulsar.MessageId.earliest)
555-
self.assertEqual(reader.topic(), f'persistent://public/default/{topic}')
556-
await reader.close()
557-
558549
async def test_schema(self):
559550
class ExampleRecord(Record): # pylint: disable=too-few-public-methods
560551
"""Example record schema for testing."""

0 commit comments

Comments
 (0)