Skip to content

Commit 58150db

Browse files
author
hqbfzwang
committed
fix test
1 parent f53a12c commit 58150db

3 files changed

Lines changed: 9 additions & 6 deletions

File tree

pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ public class ProducerImpl<T> extends ProducerBase<T> implements TimerTask, Conne
182182
private boolean errorState;
183183

184184
private final ProducerMetrics producerMetrics;
185-
// rpcLatencyHistogram 需要传递给 OpSendMsg,保留包级别访问
186185
final LatencyHistogram rpcLatencyHistogram;
187186
private final boolean pauseSendingToPreservePublishOrderOnSchemaRegFailure;
188187
// This variable can be exposed as a metrics in the future, a PIP is needed.
@@ -288,7 +287,7 @@ public ProducerImpl(PulsarClientImpl client, String topic, ProducerConfiguration
288287

289288
InstrumentProvider ip = client.instrumentProvider();
290289
producerMetrics = new ProducerMetrics(ip, topic);
291-
rpcLatencyHistogram = producerMetrics.rpcLatencyHistogram;
290+
rpcLatencyHistogram = producerMetrics.getRpcLatencyHistogram();
292291
pendingQueueFullCounter = new AtomicInteger();
293292

294293
this.connectionHandler = initConnectionHandler();

pulsar-client/src/main/java/org/apache/pulsar/client/impl/metrics/ProducerMetrics.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
public class ProducerMetrics {
2424

2525
private final LatencyHistogram sendLatencyHistogram;
26-
public final LatencyHistogram rpcLatencyHistogram;
26+
private final LatencyHistogram rpcLatencyHistogram;
2727
private final Counter publishedBytesCounter;
2828
private final UpDownCounter pendingMessagesUpDownCounter;
2929
private final UpDownCounter pendingBytesUpDownCounter;
@@ -92,4 +92,8 @@ public void recordProducerOpened() {
9292
public void recordProducerClosed() {
9393
producersClosedCounter.increment();
9494
}
95+
96+
public LatencyHistogram getRpcLatencyHistogram() {
97+
return rpcLatencyHistogram;
98+
}
9599
}

pulsar-client/src/test/java/org/apache/pulsar/client/impl/metrics/ProducerMetricsTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,10 @@ public void testRecordSendFailed() {
110110

111111
@Test
112112
public void testRpcLatencyHistogramIsAccessible() {
113-
assertNotNull(producerMetrics.rpcLatencyHistogram);
113+
assertNotNull(producerMetrics.getRpcLatencyHistogram());
114114

115-
producerMetrics.rpcLatencyHistogram.recordSuccess(TimeUnit.MILLISECONDS.toNanos(3));
116-
producerMetrics.rpcLatencyHistogram.recordFailure(TimeUnit.MILLISECONDS.toNanos(1));
115+
producerMetrics.getRpcLatencyHistogram().recordSuccess(TimeUnit.MILLISECONDS.toNanos(3));
116+
producerMetrics.getRpcLatencyHistogram().recordFailure(TimeUnit.MILLISECONDS.toNanos(1));
117117

118118
Collection<MetricData> metrics = metricReader.collectAllMetrics();
119119
assertHistogramCount(metrics, "pulsar.client.producer.rpc.send.duration", 2);

0 commit comments

Comments
 (0)