[fix][client] Add tests for ignored json fields (#3)

Author: eugene-cheverda

pulsar-client/src/test/java/org/apache/pulsar/client/impl/conf/ClientConfigurationDataTest.java

@@ -39,7 +39,7 @@ public void testDoNotPrintSensitiveInfo() throws JsonProcessingException {
         ObjectMapper objectMapper = new ObjectMapper();
         objectMapper.configure(SerializationFeature.FAIL_ON_EMPTY_BEANS, false);
         String serializedConf = objectMapper.writeValueAsString(clientConfigurationData);
-        assertThat(serializedConf).doesNotContain("xxxx", "yyyy", "zzzz");
+        assertThat(serializedConf).doesNotContain("xxxx", "yyyy", "zzzz", "serviceUrlProvider");
     }
 
 }

pulsar-client/src/test/java/org/apache/pulsar/client/impl/conf/ConsumerConfigurationDataTest.java

@@ -19,6 +19,9 @@
 package org.apache.pulsar.client.impl.conf;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.SerializationFeature;
 import java.util.regex.Pattern;
 import org.testng.annotations.DataProvider;
 import org.testng.annotations.Test;
@@ -45,4 +48,13 @@ public void testTopicConsumerConfigurationData(String topicName, int expectedPri
 
         assertThat(topicConsumerConfigurationData.getPriorityLevel()).isEqualTo(expectedPriority);
     }
+
+    @Test
+    public void testConsumerConfigurationDataSerializedWithoutIgnoredTransientFields() throws JsonProcessingException {
+        ConsumerConfigurationData<String> consumerConfigurationData = new ConsumerConfigurationData<>();
+        ObjectMapper objectMapper = new ObjectMapper();
+        objectMapper.configure(SerializationFeature.FAIL_ON_EMPTY_BEANS, false);
+        String serializedConf = objectMapper.writeValueAsString(consumerConfigurationData);
+        assertThat(serializedConf).doesNotContain("messageCrypto", "keySharedPolicy", "payloadProcessor");
+    }
 }

pulsar-client/src/test/java/org/apache/pulsar/client/impl/conf/ProducerConfigurationDataTest.java

@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.client.impl.conf;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.SerializationFeature;
+import org.testng.annotations.Test;
+
+/**
+ * Unit tests for {@link ProducerConfigurationData}.
+ */
+public class ProducerConfigurationDataTest {
+    @Test
+    public void testProducerConfigurationDataSerializedWithoutIgnoredTransientFields() throws JsonProcessingException {
+        ProducerConfigurationData producerConfigurationData = new ProducerConfigurationData();
+        ObjectMapper objectMapper = new ObjectMapper();
+        objectMapper.configure(SerializationFeature.FAIL_ON_EMPTY_BEANS, false);
+        String serializedConf = objectMapper.writeValueAsString(producerConfigurationData);
+        assertThat(serializedConf).doesNotContain("messageCrypto");
+    }
+}

pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/SchemaInfoTest.java

@@ -18,7 +18,11 @@
  */
 package org.apache.pulsar.client.impl.schema;
 
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.testng.Assert.assertEquals;
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.SerializationFeature;
 import java.util.HashMap;
 import java.util.Map;
 import org.apache.pulsar.client.api.Schema;
@@ -286,7 +290,18 @@ public static Object[][] schemas() {
 
     @Test(dataProvider = "schemas")
     public void testSchemaInfoToString(SchemaInfo si, String jsonifiedStr) {
-        assertEquals(si.toString(), jsonifiedStr);
+        String schemaInfoString = si.toString();
+        assertEquals(schemaInfoString, jsonifiedStr);
+        assertThat(schemaInfoString).doesNotContain("schemaHash");
+    }
+
+    @Test(dataProvider = "schemas")
+    public void testSerializedSchemaInfoDoesntContainIgnoredTransientFields(SchemaInfo si, String jsonifiedStr) throws
+            JsonProcessingException {
+        ObjectMapper objectMapper = new ObjectMapper();
+        objectMapper.configure(SerializationFeature.FAIL_ON_EMPTY_BEANS, false);
+        String schemaInfoString = objectMapper.writeValueAsString(si);
+        assertThat(schemaInfoString).doesNotContain("schemaHash");
     }
 
     public static class SchemaInfoBuilderTest {