Skip to content

Commit 6304ffc

Browse files
committed
[fix][broker] Optimize code
1 parent d95ad4a commit 6304ffc

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2262,11 +2262,11 @@ public void asyncMarkDelete(final Position position, Map<String, Long> propertie
22622262
boolean shouldCursorMoveForward = false;
22632263
try {
22642264
if (lastConfirmedEntry.getLedgerId() >= newPosition.getLedgerId()) {
2265-
LedgerInfo curMarkDeleteledgerInfo = ledger.getLedgerInfo(newPosition.getLedgerId()).get();
2265+
LedgerInfo curMarkDeleteLedgerInfo = ledger.getLedgerInfo(newPosition.getLedgerId()).get();
22662266
Long nextValidLedger = ledger.getNextValidLedger(newPosition.getLedgerId());
22672267
shouldCursorMoveForward = (nextValidLedger != null)
2268-
&& (curMarkDeleteledgerInfo != null
2269-
&& newPosition.getEntryId() + 1 >= curMarkDeleteledgerInfo.getEntries());
2268+
&& (curMarkDeleteLedgerInfo != null
2269+
&& newPosition.getEntryId() + 1 >= curMarkDeleteLedgerInfo.getEntries());
22702270
if (shouldCursorMoveForward) {
22712271
moveForwardPosition = PositionFactory.create(nextValidLedger, -1);
22722272
}

pulsar-broker/src/test/java/org/apache/pulsar/broker/service/MessageTTLTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ public void testMessageExpiryAfterTopicUnload() throws Exception {
116116
PersistentTopicInternalStats internalStatsAfterExpire = admin.topics().getInternalStats(topicName);
117117
CursorStats statsAfterExpire = internalStatsAfterExpire.cursors.get(subscriptionName);
118118
log.info("markDeletePosition after expire {}", statsAfterExpire.markDeletePosition);
119-
// New ledger create, move markDeletePosition to currentLedgerId:-1
119+
// New ledger created, move markDeletePosition to currentLedgerId:-1
120120
long currentLedgerId =
121121
internalStatsAfterExpire.ledgers.get(internalStatsAfterExpire.ledgers.size() - 1).ledgerId;
122122
assertEquals(statsAfterExpire.markDeletePosition,

pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactedTopicTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -833,7 +833,7 @@ public void testReadCompactedLatestMessageWithInclusive() throws Exception {
833833
long ledgerId = ((MessageIdImpl) finalLastMessage).getLedgerId();
834834
long entryId = ((MessageIdImpl) finalLastMessage).getEntryId();
835835
Assert.assertEquals(stats.lastConfirmedEntry, PositionFactory.create(ledgerId, entryId).toString());
836-
// New ledger create, move markDeletePosition to currentLedgerId:-1
836+
// New ledger created, move markDeletePosition to currentLedgerId:-1
837837
long currentLedgerId = stats.ledgers.get(stats.ledgers.size() - 1).ledgerId;
838838
Assert.assertEquals(stats.cursors.get(COMPACTION_SUBSCRIPTION).markDeletePosition,
839839
PositionFactory.create(currentLedgerId, -1).toString());

0 commit comments

Comments
 (0)