Skip to content

Commit bdfc915

Browse files
committed
Address comment
1 parent 7b250aa commit bdfc915

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,13 +241,14 @@ public NavigableSet<Position> getScheduledMessages(int maxMessages) {
241241
memoryUsage.addAndGet(-entryIds.getLongSizeInBytes());
242242
ledgerIdToDelete.add(ledgerId);
243243
} else {
244+
long oldSize = entryIds.getLongSizeInBytes();
244245
Roaring64Bitmap entryIdsToRemove = new Roaring64Bitmap();
245246
entryIds.stream().limit(n).forEach(entryId -> {
246247
positions.add(PositionFactory.create(ledgerId, entryId));
247248
entryIdsToRemove.addLong(entryId);
248249
});
249-
memoryUsage.addAndGet(entryIds.getLongSizeInBytes() - oldSize);
250250
entryIds.andNot(entryIdsToRemove);
251+
memoryUsage.addAndGet(entryIds.getLongSizeInBytes() - oldSize);
251252
delayedMessagesCount.addAndGet(-n);
252253
n = 0;
253254
}

pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedMessageIndexStats.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ enum Type {
5959
public BucketDelayedMessageIndexStats() {
6060
}
6161

62-
public Map<String, TopicMetricBean> genTopicMetricMap() {
62+
public synchronized Map<String, TopicMetricBean> genTopicMetricMap() {
6363
Map<String, TopicMetricBean> metrics = new HashMap<>();
6464

6565
metrics.put(BUCKET_TOTAL_NAME,

0 commit comments

Comments
 (0)