Skip to content

Commit eb7a4f3

Browse files
authored
[fix][test] fix flaky testNegativeAcksWithBackoff when batch enabled. (#23986)
1 parent 40d5af4 commit eb7a4f3

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

pulsar-broker/src/test/java/org/apache/pulsar/client/impl/NegativeAcksTest.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,9 +256,16 @@ public void testNegativeAcksWithBackoff(boolean batching, boolean usePartitions,
256256
long firstReceivedAt = System.currentTimeMillis();
257257
long expectedTotalRedeliveryDelay = 0;
258258
for (int i = 0; i < redeliverCount; i++) {
259+
Message<String> msg = null;
259260
for (int j = 0; j < N; j++) {
260-
Message<String> msg = consumer.receive();
261+
msg = consumer.receive();
261262
log.info("Received message {}", msg.getValue());
263+
if (!batching) {
264+
consumer.negativeAcknowledge(msg);
265+
}
266+
}
267+
if (batching) {
268+
// for batching, we only need to nack one message in the batch to trigger redelivery
262269
consumer.negativeAcknowledge(msg);
263270
}
264271
expectedTotalRedeliveryDelay += backoff.next(i);

0 commit comments

Comments
 (0)