[fix][test] Fix flaky ManagedLedgerTest.testNoRetention#25467
Merged
nodece merged 1 commit intoapache:masterfrom Apr 7, 2026
Merged
[fix][test] Fix flaky ManagedLedgerTest.testNoRetention#25467nodece merged 1 commit intoapache:masterfrom
nodece merged 1 commit intoapache:masterfrom
Conversation
Replace unreliable Thread.sleep(1000) with explicit trimConsumedLedgersInBackground + CompletableFuture.join() to deterministically wait for ledger trimming to complete.
nodece
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ManagedLedgerTest.testNoRetentionis flaky because it relies onThread.sleep(1000)for the async ledger trimming to complete, which is not always sufficient.Stack trace
Modifications
Replace
Thread.sleep(1000)with explicittrimConsumedLedgersInBackground(CompletableFuture)+join()to deterministically wait for ledger trimming to complete before asserting.Documentation
doc-not-needed