[fix][fn] Fix functions update issue where artifact is provided as a http url#25840
Merged
Conversation
Contributor
Author
|
My gradle know-how failed me - test updated |
Member
btw. there's some instructions in https://github.com/apache/pulsar#build. We recently switched to Gradle so the contributor guide hasn't been updated yet. Running all tests locally is not feasible. For larger changes it's useful to setup "Personal CI" so that you can run Pulsar CI in your own fork with GitHub Actions (free). That way you have full control and wouldn't have to wait for maintainer approvals to run builds. For this PR it's not relevant since this is a very small change. |
dao-jun
approved these changes
May 21, 2026
nodece
reviewed
May 21, 2026
nodece
approved these changes
May 21, 2026
Co-authored-by: Zixuan Liu <nodeces@gmail.com>
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
May 27, 2026
…http url (apache#25840) Co-authored-by: Stephen Bourke <sbourke@beyond.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> Co-authored-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 235a7a8)
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 9, 2026
…http url (apache#25840) Co-authored-by: Stephen Bourke <sbourke@beyond.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> Co-authored-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 235a7a8) (cherry picked from commit c05d208)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25839
Modifications
Verifying this change
This change added tests and can be verified as follows:
Updated unit test: AbstractFunctionApiResourceTest
Does this pull request potentially affect one of the following parts: