[fix][test] Fix flaky AdminApiTest.partitionedTopicsCursorReset#25847
Merged
nodece merged 1 commit intoMay 21, 2026
Conversation
After consumer.close() returns, the broker may not yet have processed the consumer-disconnect when deleteSubscription is called, causing the precondition check to fail with HTTP 412 "Subscription has active connected consumers". Retry the delete via Awaitility, ignoring PreconditionFailedException, until the broker has detected the disconnect.
nodece
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
AdminApiTest.partitionedTopicsCursorResetis flaky in CI. Recent example: PR #25844 run 26175306430 job 77005757000.consumer.close()returns once the close request has been dispatched to the broker, but the broker may not yet have processed the disconnect when the test immediately callsadmin.topics().deleteSubscription(...). The broker's precondition check still sees a connected consumer and returns HTTP 412.Modifications
Wrap the
deleteSubscriptioncall inAwaitility.await().ignoreExceptionsInstanceOf(PreconditionFailedException.class).untilAsserted(...)so the test retries the delete until the broker has detected the consumer disconnect.Verifying this change
This change is already covered by existing tests, such as the modified
partitionedTopicsCursorResettest itself.