From e1ca6f641bcd4889e31087c3dafe626257fb9b16 Mon Sep 17 00:00:00 2001 From: Dhaval Rajpara Date: Mon, 9 Mar 2026 16:14:23 +0530 Subject: [PATCH 1/4] =?UTF-8?q?RANGER-5444=20:=20Policy=20Form=20Improveme?= =?UTF-8?q?nts=20=E2=80=93=20Label=20Corrections=20&=20Layout=20Updates?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../react-webapp/src/components/Editable.jsx | 11 ++--- .../webapp/react-webapp/src/styles/style.css | 20 +++++++++ .../react-webapp/src/utils/XAMessages.js | 4 +- .../Admin/AdminLogs/PolicyViewDetails.jsx | 18 ++++---- .../GovernedData/Dataset/AccessGrantForm.jsx | 1 + .../PolicyListing/AddUpdatePolicyForm.jsx | 18 ++++---- .../PolicyListing/PolicyPermissionItem.jsx | 42 ++++++++++++------- .../src/views/Reports/SearchPolicyTable.jsx | 26 +++++------- .../ServiceManager/ServiceAuditFilter.jsx | 1 + 9 files changed, 88 insertions(+), 53 deletions(-) diff --git a/security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx b/security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx index c5754ac958..1da09a165e 100644 --- a/security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx +++ b/security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx @@ -387,7 +387,8 @@ const Editable = (props) => { options = [], conditionDefVal, servicedefName, - isGDS + isGDS, + popOverheader } = props; const initialLoad = useRef(true); @@ -451,7 +452,9 @@ const Editable = (props) => {
{`${conditionObj.label}: ${ @@ -729,9 +732,7 @@ const Editable = (props) => { type === TYPE_CHECKBOX && "popover-maxHeight popover-minHeight" }`} > - - {type === TYPE_CHECKBOX ? "Select" : "Enter"} - + {popOverheader} {type === TYPE_CHECKBOX ? ( ), policyConditionInfoIcon: - "1. JavaScript Condition Examples :\ + "1. Boolean expression Examples :\ country_code == 'USA', time_range >= 900 time_range <= 1800 etc.\ - 2. Dragging bottom-right corner of javascript condition editor(Textarea) can resizable", + 2. Dragging bottom-right corner of condition editor(Textarea) can resizable", firstNameValidationMsg: ( <>

diff --git a/security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/Admin/AdminLogs/PolicyViewDetails.jsx b/security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/Admin/AdminLogs/PolicyViewDetails.jsx index 2c96e1559b..6e13cd94e1 100644 --- a/security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/Admin/AdminLogs/PolicyViewDetails.jsx +++ b/security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/Admin/AdminLogs/PolicyViewDetails.jsx @@ -377,7 +377,7 @@ export function PolicyViewDetails(props) { Select User {!isEmpty( filterServiceDef && filterServiceDef.policyConditions - ) && Policy Conditions} + ) && Rule Conditions} {policyType == RangerPolicyType.RANGER_ACCESS_POLICY_TYPE.value ? "Permissions" @@ -682,14 +682,14 @@ export function PolicyViewDetails(props) { {getPolicyConditions(conditions, serviceDef)} {policyType == RangerPolicyType.RANGER_ACCESS_POLICY_TYPE.value && ( <> -

Allow Conditions :

+

Allow Rules :

{getFilterPolicy( policyItems, serviceDef, serviceType, - ` No policy items of "Allow Conditions" are present` + ` No policy items of "Allow Rules" are present` )}
@@ -700,7 +700,7 @@ export function PolicyViewDetails(props) { {policyType == RangerPolicyType.RANGER_ACCESS_POLICY_TYPE.value && serviceDef?.options?.enableDenyAndExceptionsInPolicies == "true" && ( <> -

Exclude from Allow Conditions :

+

Exclude from Allow Rules :

@@ -742,7 +742,7 @@ export function PolicyViewDetails(props) { policyType == RangerPolicyType.RANGER_ACCESS_POLICY_TYPE.value && serviceDef?.options?.enableDenyAndExceptionsInPolicies == "true" && ( <> -

Deny Conditions :

+

Deny Rules :

@@ -764,7 +764,7 @@ export function PolicyViewDetails(props) { policyType == RangerPolicyType.RANGER_ACCESS_POLICY_TYPE.value && serviceDef?.options?.enableDenyAndExceptionsInPolicies == "true" && ( <> -

Exclude from Deny Conditions :

+

Exclude from Deny Rules :

diff --git a/security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/AccessGrantForm.jsx b/security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/AccessGrantForm.jsx index 2d20250ee4..36c804331b 100755 --- a/security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/AccessGrantForm.jsx +++ b/security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/AccessGrantForm.jsx @@ -608,6 +608,7 @@ function AccessGrantForm({ isMulti: true }} isGDS={true} + popOverheader="Policy Conditions" /> )} diff --git a/security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx b/security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx index 98d7d31507..f4820ee0e1 100644 --- a/security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx +++ b/security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx @@ -1589,7 +1589,11 @@ export default function AddUpdatePolicyForm() { {isMultiResources && ( <>
-

Resources :

+

+ {serviceCompDetails.name == "tag" + ? "Tags :" + : "Resources :"} +

<> @@ -1656,7 +1660,7 @@ export default function AddUpdatePolicyForm() { <>

- Allow Conditions:{" "} + Allow Rules:{" "}

@@ -1684,7 +1688,7 @@ export default function AddUpdatePolicyForm() {

- Exclude from Allow Conditions: + Exclude from Allow Rules:

@@ -1750,7 +1754,7 @@ export default function AddUpdatePolicyForm() { <>

- Deny Conditions: + Deny Rules:

@@ -1776,7 +1780,7 @@ export default function AddUpdatePolicyForm() {

- Exclude from Deny Conditions: + Exclude from Deny Rules:

@@ -1811,7 +1815,7 @@ export default function AddUpdatePolicyForm() { <>

- Mask Conditions: + Mask Rules:

@@ -1843,7 +1847,7 @@ export default function AddUpdatePolicyForm() { <>

- Row Filter Conditions: + Row Filter Rules:

diff --git a/security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx b/security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx index 69325c2dd3..7f6133789a 100644 --- a/security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx +++ b/security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx @@ -76,7 +76,7 @@ export default function PolicyPermissionItem(props) { const permList = ["Select Roles", "Select Groups", "Select Users"]; if (serviceCompDetails?.policyConditions?.length > 0) { - permList.push("Policy Conditions"); + permList.push("Rule Conditions"); } permList.push("Permissions"); if ( @@ -100,7 +100,14 @@ export default function PolicyPermissionItem(props) { const tableHeader = () => { return permList.map((data) => { - return
; + return ( + + ); }); }; @@ -244,10 +251,10 @@ export default function PolicyPermissionItem(props) { if ((users || grps || roles) && !accTypes) { if (delegateAdmin !== undefined && delegateAdmin === false) { error = - "Please select permision item for selected users/groups/roles"; + "Please select permission item for selected users/groups/roles"; } else if (delegateAdmin == undefined) { error = - "Please select permision item for selected users/groups/roles"; + "Please select permission item for selected users/groups/roles"; } } if (accTypes && !users && !grps && !roles) { @@ -278,7 +285,7 @@ export default function PolicyPermissionItem(props) { !roles ) { error = - "Please select user/group/role for the entered policy condition"; + "Please select user/group/role for the entered Rule Condition"; } } return error; @@ -289,7 +296,6 @@ export default function PolicyPermissionItem(props) { ...selectInputCustomStyles, control: (base) => ({ ...base, - width: 200, whiteSpace: "nowrap" }) }; @@ -321,7 +327,7 @@ export default function PolicyPermissionItem(props) { return (
-
+
{data} + {data} +
{tableHeader()} - + @@ -354,7 +360,7 @@ export default function PolicyPermissionItem(props) { className="form-control" name={`${name}.roles`} render={({ input }) => ( -
+
( -
+
( -
+
); } - if (colName == "Policy Conditions") { + if (colName == "Rule Conditions") { return ( serviceCompDetails?.policyConditions?.length > 0 && ( @@ -461,15 +467,16 @@ export default function PolicyPermissionItem(props) { ) } render={({ input }) => ( -
+
)} @@ -548,6 +555,7 @@ export default function PolicyPermissionItem(props) { options={accessTypeOptions} showSelectAll={true} selectAllLabel="Select All" + popOverheader="Add/Edit Permissions" />
); @@ -583,6 +591,7 @@ export default function PolicyPermissionItem(props) { fields?.value[index]?.accesses ?.tableList } + popOverheader="Select Masking Option" /> {fields?.value[index]?.dataMaskInfo ?.label == "Custom" && ( @@ -650,6 +659,7 @@ export default function PolicyPermissionItem(props) { options={getMaskingAccessTypeOptions()} showSelectAll={false} selectAllLabel="Select All" + popOverheader="Select Masking Option" /> {fields?.value[index]?.dataMaskInfo ?.label == "Custom" && ( @@ -694,6 +704,7 @@ export default function PolicyPermissionItem(props) { {...input} placement="auto" type="input" + popOverheader="Enter Filter Expression" /> {meta.touched && meta.error && ( {meta.error} @@ -712,6 +723,7 @@ export default function PolicyPermissionItem(props) {
; })} -
{colName}
+