Commit 203e34b
committed
Avoid receive failures when client settings are absent
ReceiveMessageActivity can be invoked before cached gRPC client settings are available. Treat missing settings the same as the existing default-settings path so receive validation and pop handling can return a structured response instead of failing with a NullPointerException.
Constraint: Related to #8714
Confidence: high
Scope-risk: narrow
Directive: Keep missing client settings on the default consumer path unless the protocol starts requiring an explicit settings handshake before receive.
Tested: mvn -pl proxy -Dtest=ReceiveMessageActivityTest test
Not-tested: Full repository test suite1 parent 8242c1e commit 203e34b
2 files changed
Lines changed: 44 additions & 0 deletions
File tree
- proxy/src
- main/java/org/apache/rocketmq/proxy/grpc/v2/consumer
- test/java/org/apache/rocketmq/proxy/grpc/v2/consumer
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
68 | 71 | | |
69 | 72 | | |
70 | 73 | | |
| |||
Lines changed: 41 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
420 | 420 | | |
421 | 421 | | |
422 | 422 | | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
423 | 464 | | |
424 | 465 | | |
425 | 466 | | |
| |||
0 commit comments