[ISSUE #8714]#10252
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10252 +/- ##
=============================================
- Coverage 48.99% 48.89% -0.10%
- Complexity 13393 13435 +42
=============================================
Files 1373 1375 +2
Lines 99904 100414 +510
Branches 12901 12969 +68
=============================================
+ Hits 48944 49095 +151
- Misses 45038 45306 +268
- Partials 5922 6013 +91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for looking into this issue, @zhaohai666. After reviewing the changes, I don't think patching the server side is the right approach here. The The server is behaving correctly by expecting valid client settings to be present. The proper fix should be on the client side (e.g., the Node.js SDK Adding defensive null checks on the server to compensate for incomplete client implementations sets a bad precedent — it shifts the contract and could hide future client-side bugs as well. I'd suggest investigating why the client SDK loses its Telemetry session over time and fixing it there instead. |
[ISSUE #8714]