[ISSUE #10270] Make Pop RocksDB BlockCache size configurable via MessageStoreConfig#10271
Conversation
…a MessageStoreConfig Add popRocksdbBlockCacheSize to MessageStoreConfig with a default of 256MB, replacing the hardcoded value in RocksDBOptionsFactory.createPopCFOptions(). Default ColumnFamily uses a minimal 16MB cache since it stores no meaningful data. This allows operators to tune Pop RocksDB memory usage based on container memory budgets. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10271 +/- ##
=============================================
- Coverage 48.96% 48.90% -0.06%
+ Complexity 13461 13450 -11
=============================================
Files 1375 1375
Lines 100436 100448 +12
Branches 12971 12971
=============================================
- Hits 49178 49127 -51
- Misses 45266 45322 +56
- Partials 5992 5999 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for making the Pop RocksDB BlockCache size configurable — this is a good step toward better memory tuning in container environments. One thing worth considering: It would be great to also expose Happy to discuss further if needed. |
… properties Add writeBufferSize to MessageStoreConfig with a default of 32MB, replacing the hardcoded value in createPopCFOptions(). maxWriteBufferNumber and minWriteBufferNumberToMerge remain hardcoded as they rarely need tuning. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
LGTM, thanks for the quick update! |
Add popRocksdbBlockCacheSize to MessageStoreConfig with a default of 256MB, replacing the hardcoded value in RocksDBOptionsFactory.createPopCFOptions(). This allows operators to tune Pop RocksDB memory usage based on container memory budgets.
Which Issue(s) This PR Fixes
Brief Description
How Did You Test This Change?