[ISSUE #10384] Enforce Lite exclusive subscription eviction via server-side tombstones#10386
Open
f1amingo wants to merge 1 commit into
Open
[ISSUE #10384] Enforce Lite exclusive subscription eviction via server-side tombstones#10386f1amingo wants to merge 1 commit into
f1amingo wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10386 +/- ##
=============================================
+ Coverage 48.89% 48.99% +0.09%
- Complexity 13452 13495 +43
=============================================
Files 1376 1377 +1
Lines 100527 100577 +50
Branches 12983 12988 +5
=============================================
+ Hits 49154 49274 +120
+ Misses 45383 45291 -92
- Partials 5990 6012 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RongtongJin
previously approved these changes
May 27, 2026
b41513f to
7e9cf02
Compare
Lite exclusive eviction relied on a fire-and-forget unsubscribe notification. When the client missed it, the old consumer kept pulling, causing double consumption. Add a broker-local, in-memory tombstone keyed by (clientId, lmqName): - Written synchronously on eviction, before client notification. - Checked at the Lite pull entry; rejected pulls reuse "no message available", requiring no client change. - Lifecycle-aligned with the subscription set: cleared on resubscription, full-sync reconciliation, and disconnect/timeout. - Self-heals lost notifications by re-sending unsubscribe when a heartbeat still reports a tombstoned lmqName. Tests: add ExclusiveEvictionTombstonesTest; extend registry and pull-path tests to cover eviction, self-clear, reconciliation, and cleanup.
7e9cf02 to
33c0242
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
Lite exclusive eviction relied on a fire-and-forget unsubscribe notification. When the client missed it, the old consumer kept pulling, causing double consumption and breaking the exclusive contract.This PR adds a broker-local, in-memory tombstone keyed by (clientId, lmqName) as a server-side fallback:
How Did You Test This Change?