[ISSUE #407] Support wildcard IPs in ACL whitelist#10596
Open
itxaiohanglover wants to merge 1 commit into
Open
[ISSUE #407] Support wildcard IPs in ACL whitelist#10596itxaiohanglover wants to merge 1 commit into
itxaiohanglover wants to merge 1 commit into
Conversation
IPAddressUtils.isIPInRange did not recognize 0.0.0.0, ::, or * as wildcard addresses. When a user configured 0.0.0.0 in the ACL IP whitelist, it only matched the exact IP 0.0.0.0 instead of all IPs. Add support for: - 0.0.0.0 and 0.0.0.0/0: match any IPv4 address - :: and ::/0: match any IPv6 address - *: match any address Added test cases for all wildcard patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes apache/rocketmq-dashboard#407. IPAddressUtils.isIPInRange did not recognize 0.0.0.0, ::, or * as wildcard addresses. When users configured 0.0.0.0 in ACL IP whitelist, it only matched the exact IP instead of all IPs.