Skip to content

[ISSUE #9309]opti:Avoid the generation of dirty data in #assignResetOffset#9310

Merged
tianliuliu merged 7 commits into
apache:developfrom
3424672656:reset_lmq_offset
Jul 9, 2025
Merged

[ISSUE #9309]opti:Avoid the generation of dirty data in #assignResetOffset#9310
tianliuliu merged 7 commits into
apache:developfrom
3424672656:reset_lmq_offset

Conversation

@3424672656
Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Fixes #9309

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 3, 2025

Codecov Report

❌ Patch coverage is 16.66667% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.93%. Comparing base (586a274) to head (c32306d).
⚠️ Report is 281 commits behind head on develop.

Files with missing lines Patch % Lines
...cketmq/broker/offset/LmqConsumerOffsetManager.java 0.00% 17 Missing ⚠️
...etmq/broker/config/v2/ConsumerOffsetManagerV2.java 33.33% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9310      +/-   ##
=============================================
- Coverage      48.12%   47.93%   -0.19%     
+ Complexity     12140    12013     -127     
=============================================
  Files           1322     1312      -10     
  Lines          93237    92696     -541     
  Branches       11957    11856     -101     
=============================================
- Hits           44868    44434     -434     
+ Misses         42830    42748      -82     
+ Partials        5539     5514      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@3424672656 3424672656 changed the title [ISSUE #9309]feat: support clients to reset lmq consumption offset [ISSUE #9309]feat: support clients to reset lmq consumer offset Apr 24, 2025
hqbfzwang added 2 commits April 25, 2025 16:46
tianliuliu
tianliuliu previously approved these changes Apr 25, 2025
topic, group, queueId, offset);
return;
}
if (!MixAll.isLmq(topic) || !MixAll.isLmq(group)) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@3424672656 3424672656 closed this Apr 27, 2025
@3424672656 3424672656 changed the title [ISSUE #9309]feat: support clients to reset lmq consumer offset [ISSUE #9309]opti:Avoid the generation of dirty data in #assignResetOffset Jul 8, 2025
@3424672656 3424672656 reopened this Jul 8, 2025
@tianliuliu tianliuliu self-requested a review July 8, 2025 11:24
@tianliuliu tianliuliu merged commit 9337904 into apache:develop Jul 9, 2025
13 of 19 checks passed
hechen0 pushed a commit to hechen0/rocketmq that referenced this pull request Aug 18, 2025
…ResetOffset (apache#9310)

* feat: support clients to reset lmq consumption offset

* fix

* fix

* fix

* fix: clean pull offset in #removeOffset

* fix: clean pull offset in #removeOffset

* rerun test

---------

Co-authored-by: hqbfzwang <hqbfzwang@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]opti:Avoid the generation of dirty data in #assignResetOffset

3 participants