fix：use the same connection to send the heartbeat for keepalive.#9950
Closed
qsrg wants to merge 3 commits intoapache:developfrom
Closed
fix：use the same connection to send the heartbeat for keepalive.#9950qsrg wants to merge 3 commits intoapache:developfrom
qsrg wants to merge 3 commits intoapache:developfrom
Conversation
humkum
reviewed
Dec 24, 2025
| request.setLanguage(clientConfig.getLanguage()); | ||
| request.setBody(heartbeatData.encode()); | ||
| RemotingCommand response = this.remotingClient.invokeSync(addr, request, timeoutMillis); | ||
| RemotingCommand response = this.remotingClient.invokeSync((MixAll.brokerVIPChannel(this.clientConfig.isVipChannelEnabled(), addr)), request, timeoutMillis); |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9950 +/- ##
=============================================
- Coverage 48.96% 48.91% -0.06%
+ Complexity 13464 13452 -12
=============================================
Files 1375 1375
Lines 100450 100450
Branches 12973 12973
=============================================
- Hits 49183 49131 -52
- Misses 45268 45312 +44
- Partials 5999 6007 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
humkum
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9949
Brief Description
How Did You Test This Change?