You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I fetched this PR locally. The Hadoop 3.3.4 upgrade itself looks straightforward, but I found one regression in the engine server module that should be fixed before merge.
In seatunnel-engine/seatunnel-engine-server/pom.xml, the change drops <scope>test</scope> from com.squareup.okhttp:mockwebserver while keeping the dependency used only in src/test/java/org/apache/seatunnel/engine/server/event/JobEventHttpReportHandlerTest.java. That promotes a pure test helper into the main runtime dependency set of seatunnel-engine-server, which will unnecessarily leak it into the shipped server artifact and downstream dependency graph.
Please keep mockwebserver as a test-scoped dependency. The module-specific compiler-plugin override added in the same diff also looks suspicious and should be justified separately if it is really required for this upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.