[GH-1973] Upgrade to GeoTools 33 (#1967)

* Upgrade to geotools33

* update geotools in examples

* ran spotless

* revert changes that are out of the main run

* Update workflows to use geotools 33

* Update .github/workflows/pyflink.yml

* Update examples/spark-sql/pom.xml

* Update .github/workflows/docker-build.yml

* update r workflow

* use the specialized 33.1-rc1 for the geotools wrapper workflow

---------

Co-authored-by: Jia Yu <jiayu@wherobots.com>

Author: jesspav

.github/workflows/docker-build.yml

@@ -46,17 +46,14 @@ jobs:
       fail-fast: true
       matrix:
         os: ['ubuntu-latest']
-        spark: ['3.5.1', '3.4.3', '3.3.4']
+        spark: ['3.5.1', '3.4.3']
         include:
           - spark: 3.5.1
             sedona: 'latest'
-            geotools: 'auto'
+            geotools: '33.1-rc1'
           - spark: 3.4.3
             sedona: 1.6.0
             geotools: 28.2
-          - spark: 3.3.4
-            sedona: 1.6.0
-            geotools: 28.2
     runs-on: ${{ matrix.os }}
     defaults:
       run:

.github/workflows/example.yml

@@ -50,9 +50,6 @@ jobs:
           - spark: 3.4.2
             spark-compat: '3.4'
             sedona: 1.5.1
-          - spark: 3.3.4
-            spark-compat: '3.0'
-            sedona: 1.5.1
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-java@v4

.github/workflows/pyflink.yml

@@ -71,6 +71,6 @@ jobs:
       - run: uv add apache-flink==1.20.1 shapely attr setuptools
       - run: uv add pytest --dev
       - run: |
-          wget https://repo1.maven.org/maven2/org/datasyslab/geotools-wrapper/1.7.1-28.5/geotools-wrapper-1.7.1-28.5.jar
-          export SEDONA_PYFLINK_EXTRA_JARS=${PWD}/$(find flink-shaded/target -name sedona-flink*.jar),${PWD}/geotools-wrapper-1.7.1-28.5.jar
+          wget https://repo1.maven.org/maven2/org/datasyslab/geotools-wrapper/1.8.0-33.1-rc1/geotools-wrapper-1.8.0-33.1-rc1.jar
+          export SEDONA_PYFLINK_EXTRA_JARS=${PWD}/$(find flink-shaded/target -name sedona-flink*.jar),${PWD}/geotools-wrapper-1.8.0-33.1-rc1.jar
           (cd python; PYTHONPATH=$(pwd) uv run pytest -v -s ./tests/flink)

.github/workflows/r.yml

@@ -124,7 +124,7 @@ jobs:
       - name: Build Sedona libraries
         run: |
           SPARK_COMPAT_VERSION=${SPARK_VERSION:0:3}
-          mvn -q clean install -DskipTests -Dspark=${SPARK_COMPAT_VERSION} -Dscala=${SCALA_VERSION:0:4}
+          mvn -q clean install -DskipTests -Dspark=${SPARK_COMPAT_VERSION} -Dscala=${SCALA_VERSION:0:4} -Dgeotools
       - name: Run tests
         run: |
           if [[ "${SPARK_VERSION:0:3}" < "3.3" ]]; then

common/src/main/java/org/apache/sedona/common/FunctionsGeoTools.java

@@ -19,6 +19,12 @@
 package org.apache.sedona.common;
 
 import java.util.Set;
+import org.geotools.api.referencing.FactoryException;
+import org.geotools.api.referencing.NoSuchAuthorityCodeException;
+import org.geotools.api.referencing.ReferenceIdentifier;
+import org.geotools.api.referencing.crs.CoordinateReferenceSystem;
+import org.geotools.api.referencing.operation.MathTransform;
+import org.geotools.api.referencing.operation.TransformException;
 import org.geotools.geometry.jts.JTS;
 import org.geotools.referencing.CRS;
 import org.geotools.referencing.ReferencingFactoryFinder;
@@ -28,12 +34,6 @@
 import org.locationtech.jts.operation.buffer.BufferOp;
 import org.locationtech.jts.operation.buffer.BufferParameters;
 import org.locationtech.jts.triangulate.VoronoiDiagramBuilder;
-import org.opengis.referencing.FactoryException;
-import org.opengis.referencing.NoSuchAuthorityCodeException;
-import org.opengis.referencing.ReferenceIdentifier;
-import org.opengis.referencing.crs.CoordinateReferenceSystem;
-import org.opengis.referencing.operation.MathTransform;
-import org.opengis.referencing.operation.TransformException;
 
 public class FunctionsGeoTools {
 
@@ -202,8 +202,6 @@ public static Geometry bufferSpheroid(Geometry geometry, double radius, BufferPa
     if (Functions.crossesDateLine(geometry)) {
       Functions.shiftLongitude(geometry);
     }
-    // geometry = (Predicates.crossesDateLine(geometry)) ? Functions.shiftLongitude(geometry)
-    // : geometry;
 
     // If originalCRS is not set, use WGS84 as the originalCRS for transformation
     String sourceCRSCode = (originalCRS == 0) ? "EPSG:" + WGS84CRS : "EPSG:" + originalCRS;

common/src/main/java/org/apache/sedona/common/raster/GeometryFunctions.java

@@ -20,12 +20,12 @@
 
 import java.awt.geom.Point2D;
 import org.apache.sedona.common.utils.RasterUtils;
+import org.geotools.api.referencing.FactoryException;
+import org.geotools.api.referencing.operation.TransformException;
 import org.geotools.coverage.grid.GridCoordinates2D;
 import org.geotools.coverage.grid.GridCoverage2D;
-import org.geotools.geometry.Envelope2D;
+import org.geotools.geometry.jts.ReferencedEnvelope;
 import org.locationtech.jts.geom.*;
-import org.opengis.referencing.FactoryException;
-import org.opengis.referencing.operation.TransformException;
 
 public class GeometryFunctions {
 
@@ -140,7 +140,7 @@ public static void ensureSafeBand(GridCoverage2D raster, int band)
   }
 
   public static Geometry envelope(GridCoverage2D raster) throws FactoryException {
-    Envelope2D envelope2D = raster.getEnvelope2D();
+    ReferencedEnvelope envelope2D = raster.getEnvelope2D();
 
     Envelope envelope =
         new Envelope(

common/src/main/java/org/apache/sedona/common/raster/PixelFunctionEditors.java

@@ -25,10 +25,10 @@
 import javax.media.jai.RasterFactory;
 import org.apache.commons.lang3.tuple.Pair;
 import org.apache.sedona.common.utils.RasterUtils;
+import org.geotools.api.referencing.FactoryException;
+import org.geotools.api.referencing.operation.TransformException;
 import org.geotools.coverage.grid.GridCoverage2D;
 import org.locationtech.jts.geom.Geometry;
-import org.opengis.referencing.FactoryException;
-import org.opengis.referencing.operation.TransformException;
 
 public class PixelFunctionEditors {
 

common/src/main/java/org/apache/sedona/common/raster/PixelFunctions.java

@@ -25,15 +25,15 @@
 import java.util.List;
 import org.apache.commons.lang3.tuple.Pair;
 import org.apache.sedona.common.utils.RasterUtils;
+import org.geotools.api.coverage.PointOutsideCoverageException;
+import org.geotools.api.geometry.Position;
+import org.geotools.api.referencing.FactoryException;
+import org.geotools.api.referencing.operation.TransformException;
 import org.geotools.coverage.grid.GridCoordinates2D;
 import org.geotools.coverage.grid.GridCoverage2D;
-import org.geotools.geometry.DirectPosition2D;
+import org.geotools.geometry.Position2D;
 import org.geotools.referencing.operation.transform.AffineTransform2D;
 import org.locationtech.jts.geom.*;
-import org.opengis.coverage.PointOutsideCoverageException;
-import org.opengis.geometry.DirectPosition;
-import org.opengis.referencing.FactoryException;
-import org.opengis.referencing.operation.TransformException;
 
 public class PixelFunctions {
   private static GeometryFactory GEOMETRY_FACTORY = new GeometryFactory();
@@ -289,7 +289,7 @@ public static List<Double> values(GridCoverage2D rasterGeom, List<Geometry> geom
         result.add(null);
       } else {
         Point point = ensurePoint(geom);
-        DirectPosition directPosition2D = new DirectPosition2D(point.getX(), point.getY());
+        Position directPosition2D = new Position2D(point.getX(), point.getY());
         try {
           rasterGeom.evaluate(directPosition2D, pixelBuffer);
           double pixel = pixelBuffer[band - 1];

common/src/main/java/org/apache/sedona/common/raster/RasterAccessors.java

@@ -23,6 +23,10 @@
 import java.util.Arrays;
 import java.util.Set;
 import org.apache.sedona.common.utils.RasterUtils;
+import org.geotools.api.referencing.FactoryException;
+import org.geotools.api.referencing.ReferenceIdentifier;
+import org.geotools.api.referencing.crs.CoordinateReferenceSystem;
+import org.geotools.api.referencing.operation.TransformException;
 import org.geotools.coverage.grid.GridCoverage2D;
 import org.geotools.coverage.grid.GridEnvelope2D;
 import org.geotools.referencing.crs.DefaultEngineeringCRS;
@@ -31,10 +35,6 @@
 import org.locationtech.jts.geom.Geometry;
 import org.locationtech.jts.geom.GeometryFactory;
 import org.locationtech.jts.geom.Point;
-import org.opengis.referencing.FactoryException;
-import org.opengis.referencing.ReferenceIdentifier;
-import org.opengis.referencing.crs.CoordinateReferenceSystem;
-import org.opengis.referencing.operation.TransformException;
 
 public class RasterAccessors {
   public static int srid(GridCoverage2D raster) throws FactoryException {

common/src/main/java/org/apache/sedona/common/raster/RasterBandAccessors.java

@@ -30,10 +30,10 @@
 import org.apache.commons.math3.stat.descriptive.moment.StandardDeviation;
 import org.apache.sedona.common.Functions;
 import org.apache.sedona.common.utils.RasterUtils;
+import org.geotools.api.referencing.FactoryException;
 import org.geotools.coverage.GridSampleDimension;
 import org.geotools.coverage.grid.GridCoverage2D;
 import org.locationtech.jts.geom.Geometry;
-import org.opengis.referencing.FactoryException;
 
 public class RasterBandAccessors {