Skip to content

[CI] gha: set default workflow permissions#1976

Merged
jiayuasu merged 1 commit into
apache:masterfrom
jbampton:set-workflow-permissions
Jun 7, 2025
Merged

[CI] gha: set default workflow permissions#1976
jiayuasu merged 1 commit into
apache:masterfrom
jbampton:set-workflow-permissions

Conversation

@jbampton

@jbampton jbampton commented Jun 5, 2025

Copy link
Copy Markdown
Member

Did you read the Contributor Guide?

Is this PR related to a ticket?

  • No this is a CI update. The PR name follows the format [CI] my subject

What changes were proposed in this PR?

Set workflow permissions

How was this patch tested?

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@jbampton jbampton requested a review from jiayuasu as a code owner June 5, 2025 22:20
@jbampton jbampton self-assigned this Jun 5, 2025
@jiayuasu

jiayuasu commented Jun 6, 2025

Copy link
Copy Markdown
Member

What is the purpose of this PR?

@jbampton

jbampton commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

zizmor is a static analysis tool for GitHub Actions. It can find many common security issues in typical GitHub Actions CI/CD setups. So I ran zizmor here and it found that we did not have our permissions set on these workflows.

https://github.com/zizmorcore/zizmor

refs #1977

The other workflows that I did not modify already had:

permissions:
  contents: read

This is the example from zizmor:

Screenshot from 2025-06-07 06-47-33

So you can compare this PR to another previous PR and see the difference in the permissions.

This PR:

Screenshot from 2025-06-07 06-53-37

Another previous PR:

Screenshot from 2025-06-07 06-56-12

@jiayuasu jiayuasu merged commit adb2b0e into apache:master Jun 7, 2025
12 checks passed
jiayuasu added a commit that referenced this pull request Jun 8, 2025
@jiayuasu

jiayuasu commented Jun 8, 2025

Copy link
Copy Markdown
Member

I had to revert this PR because our Github action actually deploys to our website branch, this PR broken the github action. Please fix accordingly: https://github.com/apache/sedona/actions/runs/15513400421

kadolor pushed a commit to kadolor/sedona that referenced this pull request Jul 29, 2025
kadolor pushed a commit to kadolor/sedona that referenced this pull request Jul 29, 2025
@jbampton jbampton deleted the set-workflow-permissions branch January 8, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants