[GH-2007] Geopandas.Dataframe: Fix constructor for pandas-on-pyspark and Sedona Geopandas input types#2008
Merged
Conversation
Member
Author
|
Whoops sorry Jia, I meant to request you for a different PR that already got approved. Too many prs and issues open. |
zhangfengcdt
approved these changes
Jun 26, 2025
zhangfengcdt
left a comment
zhangfengcdt
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix, and it looks great to me!
jiayuasu
approved these changes
Jun 26, 2025
jiayuasu
changed the title
Kontinuation
pushed a commit
to Kontinuation/sedona
that referenced
this pull request
Jan 21, 2026
…spark and Sedona Geopandas input types (apache#2008) * Fix small constructor bug * Fix condition for converting to wkb * Fix constructor to not error on sgpd and pspd inputs * Add constructor tests for all input types, including non-geometry * pre-commit reformat * Change to BaseGeometry for shapely compatibilty * pre-commit fmt * Remove empty lst and dct test cases since diff spark versions handle differently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject.What changes were proposed in this PR?
Fixed
Geodataframe.__init__()'s behavior to properly handle Sedona Geopandas and pandas-on-pyspark input types.Also made it so any column with geometry type is converted to wkb, instead of only gpd.GeoSeries
How was this patch tested?
Added tests
Did this PR include necessary documentation updates?