[GH-2022] Geopandas.GeoSeries: Implement geom_type#2023
Merged
Conversation
petern48
force-pushed
the
geom_type_series
branch
from
3c1b8d8 to
3551548
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the geom_type property for GeoSeries to return a series of geometry type strings in all caps. Key changes include:
- Adding tests in two test files to check the geom_type functionality across a variety of geometries.
- Implementing the geom_type property in GeoSeries using _process_geometry_column with appropriate documentation.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/tests/geopandas/test_match_geopandas_series.py | Added test for geom_type comparing sedona and geopandas outputs |
| python/tests/geopandas/test_geoseries.py | Added comprehensive test case for geom_type with multiple geometry types |
| python/sedona/geopandas/geoseries.py | Implemented the geom_type property with updated docstring and return type |
jiayuasu
reviewed
Jul 3, 2025
zhangfengcdt
approved these changes
Jul 3, 2025
jiayuasu
approved these changes
Jul 4, 2025
Kontinuation
pushed a commit
to Kontinuation/sedona
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes Geopandas.GeoSeries: Implement geom_type #2022What changes were proposed in this PR?
Implement geom_type
How was this patch tested?
Added tests
Did this PR include necessary documentation updates?