[GH-2041] Implement boundary, centroid, envelope#2042
Merged
Conversation
Member
Author
|
Tests are now passing again after merging in the recent changes |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the previously unimplemented boundary, centroid, and envelope properties on GeoSeries and adds corresponding end-to-end tests.
- Added concrete implementations for
GeoSeries.boundary,GeoSeries.centroid, andGeoSeries.envelopeingeoseries.py, including documentation and SQL translation logic. - Updated WKB loading in
_to_geopandasto guard null values usingpd.isna. - Expanded the pytest suite in
test_match_geopandas_series.pyandtest_geoseries.pyto validate the new methods against GeoPandas.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/tests/geopandas/test_match_geopandas_series.py | Added loops for testing boundary, centroid, and envelope cases, with a version guard for shapely boundary behavior |
| python/tests/geopandas/test_geoseries.py | Added explicit unit tests for boundary, centroid, and envelope on GeoSeries |
| python/sedona/geopandas/geoseries.py | Implemented the three new properties and improved null-handling in _to_geopandas |
jiayuasu
approved these changes
Jul 12, 2025
Subham-KRLX
pushed a commit
to Subham-KRLX/sedona
that referenced
this pull request
Jul 17, 2025
* Implement boundary * Implement centroid * Implement envelope * Skip boundary test for geom collection for shapely < 2.0.0 * Fix doc strings to use sedona instead of geoseries * Support na values in to_geopandas
Kontinuation
pushed a commit
to Kontinuation/sedona
that referenced
this pull request
Jan 21, 2026
* Implement boundary * Implement centroid * Implement envelope * Skip boundary test for geom collection for shapely < 2.0.0 * Fix doc strings to use sedona instead of geoseries * Support na values in to_geopandas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes Geopandas.GeoSeries: Implement boundary, centroid, envelope #2041What changes were proposed in this PR?
Implement boundary, centroid, envelope
How was this patch tested?
Added tests
Did this PR include necessary documentation updates?