-
Notifications
You must be signed in to change notification settings - Fork 760
[GH-2830] Adds Geography implementations for ST_Within and ST_DWithin #2858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jiayuasu
merged 6 commits into
apache:master
from
zhangfengcdt:feature/geography.support.st_dwithin
Apr 29, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fb483e0
[GH-2830] Adds Geography implementations for ST_Within and ST_DWithin
zhangfengcdt 21fcf55
add svg to the help file
zhangfengcdt 4ff1d92
implement st_witin for geography type
zhangfengcdt ae32ee2
add more unit tests
zhangfengcdt 622ad3a
address copilot comments
zhangfengcdt 7acfb60
Merge remote-tracking branch 'origin/master' into feature/geography.s…
zhangfengcdt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| --> | ||
|
|
||
| # ST_DWithin | ||
|
|
||
| Introduction: Tests whether two geographies are within a given geodesic distance (in meters) of each other on the sphere. The minimum great-circle distance between any two points on the two geographies is compared against the threshold; the test is inclusive (returns true when the minimum distance equals the threshold). | ||
|
|
||
|  | ||
|  | ||
|
|
||
| Format: | ||
|
|
||
| `ST_DWithin (A: Geography, B: Geography, distance: Double)` | ||
|
|
||
| Return type: `Boolean` | ||
|
|
||
| Since: `v1.9.1` | ||
|
|
||
| SQL Example | ||
|
|
||
| ```sql | ||
| SELECT ST_DWithin( | ||
| ST_GeogFromWKT('POINT (0 0)', 4326), | ||
| ST_GeogFromWKT('POINT (0 1)', 4326), | ||
| 200000.0 | ||
| ); | ||
| ``` | ||
|
|
||
| Output: | ||
|
|
||
| ``` | ||
| true | ||
| ``` | ||
|
|
||
| The same pair of points with a tighter threshold: | ||
|
|
||
| ```sql | ||
| SELECT ST_DWithin( | ||
| ST_GeogFromWKT('POINT (0 0)', 4326), | ||
| ST_GeogFromWKT('POINT (0 1)', 4326), | ||
| 100000.0 | ||
| ); | ||
| ``` | ||
|
|
||
| Output: | ||
|
|
||
| ``` | ||
| false | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| --> | ||
|
|
||
| # ST_Within | ||
|
|
||
| Introduction: Tests whether geography `A` is fully within geography `B` using S2 spherical boolean operations. Returns true when every point of `A`'s interior lies in `B`'s interior. By OGC convention, `ST_Within(A, B)` is equivalent to `ST_Contains(B, A)`, and shares the same boundary semantics. | ||
|
|
||
| Boundary semantics on the sphere are inherited from S2's boolean operations and depend on each ring's vertex orientation: along an edge that is "owned" by `B`'s boundary the test returns true, and along the opposite edge it returns false. Do not rely on a specific result for points that lie exactly on `B`'s boundary; for predictable behavior, use a strict interior point or expand `B` slightly with `ST_Buffer` before testing. | ||
|
|
||
|  | ||
|  | ||
|
|
||
| Format: | ||
|
|
||
| `ST_Within (A: Geography, B: Geography)` | ||
|
|
||
| Return type: `Boolean` | ||
|
|
||
| Since: `v1.9.1` | ||
|
|
||
| SQL Example — interior point: | ||
|
|
||
| ```sql | ||
| SELECT ST_Within( | ||
| ST_GeogFromWKT('POINT (0.5 0.5)', 4326), | ||
| ST_GeogFromWKT('POLYGON ((0 0, 1 0, 1 1, 0 1, 0 0))', 4326) | ||
| ); | ||
| ``` | ||
|
|
||
| Output: | ||
|
|
||
| ``` | ||
| true | ||
| ``` | ||
42 changes: 42 additions & 0 deletions
42
docs/image/ST_DWithin_geography/ST_DWithin_geography_false.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
42 changes: 42 additions & 0 deletions
42
docs/image/ST_DWithin_geography/ST_DWithin_geography_true.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.