Skip to content

Remove GraalVM Reachability Metadata and nativeTest related to Etcd's Cluster mode integration#37356

Merged
sandynz merged 1 commit into
apache:masterfrom
linghengqian:update-dep
Dec 12, 2025
Merged

Remove GraalVM Reachability Metadata and nativeTest related to Etcd's Cluster mode integration#37356
sandynz merged 1 commit into
apache:masterfrom
linghengqian:update-dep

Conversation

@linghengqian

@linghengqian linghengqian commented Dec 12, 2025

Copy link
Copy Markdown
Member

Fixes #36672 .

Changes proposed in this pull request:

  • Remove GraalVM Reachability Metadata and nativeTest related to Etcd's Cluster mode integration. Maintaining GraalVM Reachability Metadata in etcd mode separately under Windows would require introducing the devcontainer of a Linux container, which is too troublesome. [Native Image] Netty DNS Resolver is not available in GraalVM Native Image compiled on Windows oracle/graal#11280 prevents the Windows development experience.
  • Remove duplicate dependencies from the test module until the JDBC and Proxy nativeTest are finally separated into different Maven modules.
  • Change the name of the folder storing test metadata to shardingsphere-test-native, which corresponds to the Maven module name, helps to eliminate misunderstandings.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes GraalVM Reachability Metadata and nativeTest support for Etcd's Cluster mode integration due to compatibility issues with Windows 11 (oracle/graal#11280) and conflicts with the GraalVM Tracing Agent. The changes streamline the native test module and clarify documentation about Etcd support limitations.

  • Removes all Etcd-related test infrastructure and metadata
  • Cleans up duplicate dependencies from the test module's pom.xml
  • Updates documentation to reflect the removal and provide guidance for developers who need Etcd cluster mode support

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/modes/cluster/EtcdTest.java Removes the EtcdTest class that was testing cluster mode with Etcd
test/native/src/test/resources/test-native/yaml/jdbc/modes/cluster/etcd.yaml Removes the Etcd cluster configuration YAML file used by tests
test/native/src/test/resources/META-INF/native-image/shardingsphere-test-native/reachability-metadata.json Removes the GraalVM reachability metadata entry for EtcdTest
infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.shardingsphere/generated-reachability-metadata/reachability-metadata.json Removes all Etcd-related GraalVM reachability metadata entries and updates condition typeReached references
test/native/pom.xml Removes duplicate dependencies (shardingsphere-jdbc, various database drivers, jetcd-test, and others) that are already transitively included
docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/development/_index.en.md Updates documentation to remove reference to EtcdTest Windows limitation and corrects metadata folder path
docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/development/_index.cn.md Updates Chinese documentation to remove reference to EtcdTest Windows limitation and corrects metadata folder path
docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/_index.en.md Adds new limitation documentation explaining Etcd cluster mode is unavailable on Windows 11 and conflicts with GraalVM Tracing Agent
docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/_index.cn.md Adds Chinese version of the new limitation documentation for Etcd cluster mode

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sandynz
sandynz merged commit 3af5475 into apache:master Dec 12, 2025
154 checks passed
@linghengqian
linghengqian deleted the update-dep branch December 12, 2025 02:59
makssent pushed a commit to makssent/shardingsphere that referenced this pull request Apr 9, 2026
…ngsphere/master

* remotes/origin/master:
  Remove GraalVM Reachability Metadata and nativeTest related to Etcd's Cluster mode integration (apache#37356)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Execute etcd's nativeTest via JIT will conflict with the GraalVM Tracing Agent in Windows 11

3 participants