Remove GraalVM Reachability Metadata and nativeTest related to Etcd's Cluster mode integration#37356
Merged
Merged
Conversation
… Cluster mode integration
There was a problem hiding this comment.
Pull request overview
This PR removes GraalVM Reachability Metadata and nativeTest support for Etcd's Cluster mode integration due to compatibility issues with Windows 11 (oracle/graal#11280) and conflicts with the GraalVM Tracing Agent. The changes streamline the native test module and clarify documentation about Etcd support limitations.
- Removes all Etcd-related test infrastructure and metadata
- Cleans up duplicate dependencies from the test module's pom.xml
- Updates documentation to reflect the removal and provide guidance for developers who need Etcd cluster mode support
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/modes/cluster/EtcdTest.java | Removes the EtcdTest class that was testing cluster mode with Etcd |
| test/native/src/test/resources/test-native/yaml/jdbc/modes/cluster/etcd.yaml | Removes the Etcd cluster configuration YAML file used by tests |
| test/native/src/test/resources/META-INF/native-image/shardingsphere-test-native/reachability-metadata.json | Removes the GraalVM reachability metadata entry for EtcdTest |
| infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.shardingsphere/generated-reachability-metadata/reachability-metadata.json | Removes all Etcd-related GraalVM reachability metadata entries and updates condition typeReached references |
| test/native/pom.xml | Removes duplicate dependencies (shardingsphere-jdbc, various database drivers, jetcd-test, and others) that are already transitively included |
| docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/development/_index.en.md | Updates documentation to remove reference to EtcdTest Windows limitation and corrects metadata folder path |
| docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/development/_index.cn.md | Updates Chinese documentation to remove reference to EtcdTest Windows limitation and corrects metadata folder path |
| docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/_index.en.md | Adds new limitation documentation explaining Etcd cluster mode is unavailable on Windows 11 and conflicts with GraalVM Tracing Agent |
| docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/_index.cn.md | Adds Chinese version of the new limitation documentation for Etcd cluster mode |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sandynz
approved these changes
Dec 12, 2025
7 tasks
makssent
pushed a commit
to makssent/shardingsphere
that referenced
this pull request
Apr 9, 2026
…ngsphere/master * remotes/origin/master: Remove GraalVM Reachability Metadata and nativeTest related to Etcd's Cluster mode integration (apache#37356)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36672 .
Changes proposed in this pull request:
shardingsphere-test-native, which corresponds to the Maven module name, helps to eliminate misunderstandings.Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.