Skip to content

Support for the ANALYZE TABLE in Stored Procedures #37390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrymanu merged 2 commits into from
Dec 16, 2025
Merged

Support for the ANALYZE TABLE in Stored Procedures #37390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8022c03
Support for the ANALYZE TABLE in Stored Procedures
ccxxxyy Dec 15, 2025
797d499
Support for the ALTER RESOURCE statement
ccxxxyy Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parser/sql/engine/dialect/mysql/src/main/antlr4/imports/mysql/DDLStatement.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,7 @@ validStatement
| createView | prepare | executeStmt | commit | deallocate
| setVariable | beginStatement | declareStatement | flowControlStatement | cursorStatement | conditionHandlingStatement
| setStatement | showStatement | showCreateTable | startTransaction | rollback | commit | show
| alterEvent | dropEvent | doStatement | explain) SEMI_?
| alterEvent | dropEvent | doStatement | explain | analyzeTable) SEMI_?
;

showStatement
Expand Down
10 changes: 10 additions & 0 deletions ...ardingsphere/sql/parser/engine/mysql/visitor/statement/type/MySQLDDLStatementVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@
import org.apache.shardingsphere.sql.parser.autogen.MySQLStatementParser.WhileStatementContext;
import org.apache.shardingsphere.sql.parser.autogen.MySQLStatementParser.DoStatementContext;
import org.apache.shardingsphere.sql.parser.autogen.MySQLStatementParser.ExplainContext;
import org.apache.shardingsphere.sql.parser.autogen.MySQLStatementParser.AnalyzeTableContext;
import org.apache.shardingsphere.sql.parser.engine.mysql.visitor.statement.MySQLStatementVisitor;
import org.apache.shardingsphere.sql.parser.statement.core.enums.AlgorithmOption;
import org.apache.shardingsphere.sql.parser.statement.core.enums.LockTableOption;
Expand Down Expand Up @@ -154,6 +155,7 @@
import org.apache.shardingsphere.sql.parser.statement.core.segment.generic.table.SimpleTableSegment;
import org.apache.shardingsphere.sql.parser.statement.core.segment.dml.expr.ExpressionSegment;
import org.apache.shardingsphere.sql.parser.statement.core.statement.SQLStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.type.dal.AnalyzeTableStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.type.dal.ExplainStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.type.ddl.DeallocateStatement;
import org.apache.shardingsphere.sql.parser.statement.core.statement.type.ddl.ExecuteStatement;
Expand Down Expand Up @@ -861,11 +863,19 @@ private ValidStatementSegment createValidStatementSegment(final ValidStatementCo
sqlStatement = (DoStatement) visit(ctx.doStatement());
} else if (null != ctx.explain()) {
sqlStatement = (SQLStatement) visit(ctx.explain());
} else if (null != ctx.analyzeTable()) {
sqlStatement = (AnalyzeTableStatement) visit(ctx.analyzeTable());
}
result.setSqlStatement(sqlStatement);
return result;
}

@SuppressWarnings("unchecked")
@Override
public ASTNode visitAnalyzeTable(final AnalyzeTableContext ctx) {
return new AnalyzeTableStatement(getDatabaseType(), ((CollectionValue<SimpleTableSegment>) visit(ctx.tableList())).getValue());
}

@Override
public ASTNode visitDoStatement(final DoStatementContext ctx) {
List<ExpressionSegment> expressions = new LinkedList<>();
Expand Down
12 changes: 12 additions & 0 deletions test/it/parser/src/main/resources/case/ddl/create-procedure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,4 +169,16 @@
<sql-statement start-index="28" stop-index="38" statement-class-simple-name="MySQLDescribeStatement" />
</sql-statements>
</create-procedure>
<create-procedure sql-case-id="create_procedure_with_analyze_table_update">
<procedure-name name="p" />
<sql-statements>
<sql-statement start-index="24" stop-index="59" statement-class-simple-name="AnalyzeTableStatement" />
</sql-statements>
</create-procedure>
<create-procedure sql-case-id="create_procedure_with_analyze_table">
<procedure-name name="p" />
<sql-statements>
<sql-statement start-index="27" stop-index="41" statement-class-simple-name="AnalyzeTableStatement" />
</sql-statements>
</create-procedure>
</sql-parser-test-cases>
2 changes: 2 additions & 0 deletions test/it/parser/src/main/resources/sql/supported/ddl/create-procedure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,6 @@
<sql-case id="create_procedure_with_begin_do" value="create procedure t_sysdate() begin select sysdate() into @a; do sleep(2); end;" db-types="MySQL"/>
<sql-case id="create_procedure_with_describe_table" value="create procedure p1() begin describe t1; end;" db-types="MySQL"/>
<sql-case id="create_procedure_with_explain_table" value="create procedure p1() begin explain t1; end;" db-types="MySQL"/>
<sql-case id="create_procedure_with_analyze_table_update" value="CREATE PROCEDURE p() ANALYZE TABLE v UPDATE HISTOGRAM ON w;" db-types="MySQL"/>
<sql-case id="create_procedure_with_analyze_table" value="CREATE PROCEDURE p() BEGIN ANALYZE TABLE v; END;" db-types="MySQL"/>
</sql-cases>