Refactor Firebird's nativeTest#37409
Merged
Merged
Conversation
152022c to
e0d4770
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors Firebird's native test implementation to use testcontainers-jdbc driver instead of manual container management, and upgrades ClickHouse to version 25.9.6.117.
Key changes:
- Simplified Firebird test setup by leveraging testcontainers JDBC driver, eliminating manual database creation with FBManager
- Upgraded ClickHouse container version from 25.6.5.41 to 25.9.6.117
- Reorganized testcontainers database type classes into a dedicated 'type' subpackage
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/databases/FirebirdTest.java | Simplified test by removing manual container management and database creation logic |
| test/native/src/test/resources/test-native/yaml/jdbc/databases/firebird.yaml | Migrated from manual JDBC URLs with system properties to testcontainers JDBC driver URLs |
| test/native/src/test/resources/test-native/yaml/jdbc/databases/clickhouse.yaml | Updated ClickHouse version from 25.6.5.41 to 25.9.6.117 |
| test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/databases/ClickHouseTest.java | Removed unused @testcontainers annotation |
| test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/algorithm/testcontainers/type/TcFirebirdDatabaseType.java | Added new testcontainers database type implementation for Firebird |
| test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/algorithm/testcontainers/jdbcurl/TcFirebirdConnectionPropertiesParser.java | Added JDBC URL parser for Firebird testcontainers |
| test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/algorithm/testcontainers/type/*.java | Moved testcontainers database type classes to 'type' subpackage |
| test/native/src/test/resources/META-INF/services/* | Updated SPI service registrations to reflect package reorganization and add Firebird support |
| test/native/pom.xml | Added firebird-testcontainers-java dependency |
| pom.xml | Added firebird-testcontainers-java version property |
| infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.shardingsphere/generated-reachability-metadata/reachability-metadata.json | Added native-image resource configuration for Firebird error message properties files |
| docs/document/content/user-manual/shardingsphere-jdbc/optional-plugins/clickhouse/*.md | Updated ClickHouse version in documentation examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e0d4770 to
8b5a751
Compare
terrymanu
approved these changes
Dec 17, 2025
makssent
pushed a commit
to makssent/shardingsphere
that referenced
this pull request
Apr 9, 2026
…ngsphere/master * remotes/origin/master: Remove unreached codes on CDCSchemaTableUtils (apache#37414) Add test cases on ColumnValueConvertUtilsTest (apache#37413) Refactor Firebird's nativeTest (apache#37409)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #29052 .
Changes proposed in this pull request:
org.antlr:antlr4-runtimeto4.13.2to fix integration issues with clickhouse-server25.10.1+#37406,clickhouse/clickhouse-serverhas been upgraded to25.9.6.117.Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.