Skip to content

Refactor Firebird's nativeTest#37409

Merged
terrymanu merged 1 commit into
apache:masterfrom
linghengqian:firebird
Dec 17, 2025
Merged

Refactor Firebird's nativeTest#37409
terrymanu merged 1 commit into
apache:masterfrom
linghengqian:firebird

Conversation

@linghengqian
Copy link
Copy Markdown
Member

@linghengqian linghengqian commented Dec 16, 2025

For #29052 .

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors Firebird's native test implementation to use testcontainers-jdbc driver instead of manual container management, and upgrades ClickHouse to version 25.9.6.117.

Key changes:

  • Simplified Firebird test setup by leveraging testcontainers JDBC driver, eliminating manual database creation with FBManager
  • Upgraded ClickHouse container version from 25.6.5.41 to 25.9.6.117
  • Reorganized testcontainers database type classes into a dedicated 'type' subpackage

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/databases/FirebirdTest.java Simplified test by removing manual container management and database creation logic
test/native/src/test/resources/test-native/yaml/jdbc/databases/firebird.yaml Migrated from manual JDBC URLs with system properties to testcontainers JDBC driver URLs
test/native/src/test/resources/test-native/yaml/jdbc/databases/clickhouse.yaml Updated ClickHouse version from 25.6.5.41 to 25.9.6.117
test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/databases/ClickHouseTest.java Removed unused @testcontainers annotation
test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/algorithm/testcontainers/type/TcFirebirdDatabaseType.java Added new testcontainers database type implementation for Firebird
test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/algorithm/testcontainers/jdbcurl/TcFirebirdConnectionPropertiesParser.java Added JDBC URL parser for Firebird testcontainers
test/native/src/test/java/org/apache/shardingsphere/test/natived/commons/algorithm/testcontainers/type/*.java Moved testcontainers database type classes to 'type' subpackage
test/native/src/test/resources/META-INF/services/* Updated SPI service registrations to reflect package reorganization and add Firebird support
test/native/pom.xml Added firebird-testcontainers-java dependency
pom.xml Added firebird-testcontainers-java version property
infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.shardingsphere/generated-reachability-metadata/reachability-metadata.json Added native-image resource configuration for Firebird error message properties files
docs/document/content/user-manual/shardingsphere-jdbc/optional-plugins/clickhouse/*.md Updated ClickHouse version in documentation examples

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@linghengqian linghengqian marked this pull request as ready for review December 17, 2025 02:52
@linghengqian linghengqian added this to the 5.5.3 milestone Dec 17, 2025
@terrymanu terrymanu merged commit 5985f0f into apache:master Dec 17, 2025
148 checks passed
@linghengqian linghengqian deleted the firebird branch December 17, 2025 04:06
makssent pushed a commit to makssent/shardingsphere that referenced this pull request Apr 9, 2026
…ngsphere/master

* remotes/origin/master:
  Remove unreached codes on CDCSchemaTableUtils (apache#37414)
  Add test cases on ColumnValueConvertUtilsTest (apache#37413)
  Refactor Firebird's nativeTest (apache#37409)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants