Skip to content

Support for the ALTER CATALOG statement and the RESUME JOB statement#37491

Merged
terrymanu merged 2 commits into
apache:masterfrom
ccxxxyy:issueNo
Dec 25, 2025
Merged

Support for the ALTER CATALOG statement and the RESUME JOB statement#37491
terrymanu merged 2 commits into
apache:masterfrom
ccxxxyy:issueNo

Conversation

@ccxxxyy
Copy link
Copy Markdown
Contributor

@ccxxxyy ccxxxyy commented Dec 24, 2025

for #31491 , for #31501

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

Copy link
Copy Markdown
Member

@terrymanu terrymanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work expanding Doris support: adding ALTER CATALOG/RESUME JOB grammar, AST classes, and parser test cases is on the right track.

Please tighten a few points before merge:

  • Assertion coverage: test/it/parser/.../AlterCatalogStatementAssert.java:53,65 only checks rename/comment when actual is present, so missing fields slip through. When the expectation includes rename/comment, first assert isPresent() on the actual optional, then verify the value.
  • String handling: DorisDDLStatementVisitor.visitAlterCatalog manually strips quotes for properties/comment. This will mis-handle escaped or nested quotes (e.g., "a", b''c). Use SQLUtils.getExactlyValue(...) (and avoid getChild(0).getText()) to extract keys/values/ comments consistently.
  • Keyword compatibility: DorisKeyword.g4 promotes JOB to a keyword. If Doris lexer treats JOB as reserved, fine; if not, this could break identifiers previously named job. Please confirm against Doris’ official grammar and adjust if necessary.

Once these are fixed, the feature should be safe to merge. Keep it up!

@ccxxxyy
Copy link
Copy Markdown
Contributor Author

ccxxxyy commented Dec 24, 2025

@terrymanu Hi! Hope you could take a look when you have a moment. After reviewing the document, I made the necessary revision promptly.

@ccxxxyy ccxxxyy requested a review from terrymanu December 24, 2025 15:08
@terrymanu terrymanu merged commit d47c7d6 into apache:master Dec 25, 2025
145 checks passed
@terrymanu terrymanu added this to the 5.5.3 milestone Dec 25, 2025
@ccxxxyy ccxxxyy deleted the issueNo branch December 25, 2025 05:11
makssent pushed a commit to makssent/shardingsphere that referenced this pull request Apr 9, 2026
…ngsphere/master

* remotes/origin/master:
  Flag junit tests missing production classes (apache#37505)
  Align test package names with production packages (apache#37503)
  Refactor IntegerPrimaryKeyIngestPosition to support null value (apache#37502)
  Support for the ALTER CATALOG statement and the RESUME JOB statement (apache#37491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants