Support for the ALTER CATALOG statement and the RESUME JOB statement#37491
Merged
Conversation
terrymanu
requested changes
Dec 24, 2025
Member
terrymanu
left a comment
There was a problem hiding this comment.
Nice work expanding Doris support: adding ALTER CATALOG/RESUME JOB grammar, AST classes, and parser test cases is on the right track.
Please tighten a few points before merge:
- Assertion coverage: test/it/parser/.../AlterCatalogStatementAssert.java:53,65 only checks rename/comment when actual is present, so missing fields slip through. When the expectation includes rename/comment, first assert isPresent() on the actual optional, then verify the value.
- String handling: DorisDDLStatementVisitor.visitAlterCatalog manually strips quotes for properties/comment. This will mis-handle escaped or nested quotes (e.g., "a", b''c). Use SQLUtils.getExactlyValue(...) (and avoid getChild(0).getText()) to extract keys/values/ comments consistently.
- Keyword compatibility: DorisKeyword.g4 promotes JOB to a keyword. If Doris lexer treats JOB as reserved, fine; if not, this could break identifiers previously named job. Please confirm against Doris’ official grammar and adjust if necessary.
Once these are fixed, the feature should be safe to merge. Keep it up!
Contributor
Author
|
@terrymanu Hi! Hope you could take a look when you have a moment. After reviewing the document, I made the necessary revision promptly. |
terrymanu
approved these changes
Dec 25, 2025
makssent
pushed a commit
to makssent/shardingsphere
that referenced
this pull request
Apr 9, 2026
…ngsphere/master * remotes/origin/master: Flag junit tests missing production classes (apache#37505) Align test package names with production packages (apache#37503) Refactor IntegerPrimaryKeyIngestPosition to support null value (apache#37502) Support for the ALTER CATALOG statement and the RESUME JOB statement (apache#37491)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #31491 , for #31501
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.