Remove defer unlock when goroutine change (#228)

mrproliu · web-flow · commit 654a5930e77d · 2025-07-18T07:13:51.000+02:00
diff --git a/plugins/core/context.go b/plugins/core/context.go
@@ -57,11 +57,12 @@ func (t *TracingContext) TakeSnapShot() interface{} {
 
 func (t *TracingContext) ActiveSpan() TracingSpan {
 	t.activeSpanLock.RLock()
-	defer t.activeSpanLock.RUnlock()
-	if t.activeSpan == nil || reflect.ValueOf(t.activeSpan).IsZero() {
+	data := t.activeSpan
+	t.activeSpanLock.RUnlock()
+	if data == nil || reflect.ValueOf(data).IsZero() {
 		return nil
 	}
-	return t.activeSpan
+	return data
 }
 
 func (t *TracingContext) SaveActiveSpan(s TracingSpan) {

Original file line number	Diff line number	Diff line change
`@@ -57,11 +57,12 @@ func (t *TracingContext) TakeSnapShot() interface{} {`
`57`	`57`
`58`	`58`	`func (t *TracingContext) ActiveSpan() TracingSpan {`
`59`	`59`	`t.activeSpanLock.RLock()`
`60`		`- defer t.activeSpanLock.RUnlock()`
`61`		`- if t.activeSpan == nil \|\| reflect.ValueOf(t.activeSpan).IsZero() {`
	`60`	`+ data := t.activeSpan`
	`61`	`+ t.activeSpanLock.RUnlock()`
	`62`	`+ if data == nil \|\| reflect.ValueOf(data).IsZero() {`
`62`	`63`	`return nil`
`63`	`64`	`}`
`64`		`- return t.activeSpan`
	`65`	`+ return data`
`65`	`66`	`}`
`66`	`67`
`67`	`68`	`func (t *TracingContext) SaveActiveSpan(s TracingSpan) {`