Skip to content

Commit 59237c4

Browse files
authored
Fix the SenderSendInterceptor in the nutz-plugin/http-1.x-plugin to avoid NPE caused by the Response status (#815)
1 parent 67c9afa commit 59237c4

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ Release Notes.
3232
* Fix an issue where `JDBCPluginConfig.Plugin.JDBC.SQL_BODY_MAX_LENGTH` was not honored by clickhouse-0.3.1 and clickhouse-0.3.2.x plugins.
3333
- Add tracing support for vector-store retrieval operations.
3434
* Fix agent lifecycle events: the Start event now carries the service instance name, and the Shutdown event is delivered on graceful JVM exit. `ServiceManager` prepares/starts higher-priority `BootService`s first and shuts them down last (matching `BootService#priority()`), and the shutdown event refreshes its gRPC deadline before sending.
35+
* Fix the `SenderSendInterceptor` in the nutz-plugins/http-1.x-plugin to avoid NPE caused by the Response status.
3536

3637
All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/249?closed=1)
3738

apm-sniffer/apm-sdk-plugin/nutz-plugins/http-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/nutz/http/sync/SenderSendInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public Object afterMethod(final EnhancedInstance objInst, final Method method, f
6565
Response response = (Response) ret;
6666
AbstractSpan span = ContextManager.activeSpan();
6767

68-
if (response == null) {
68+
if (response != null) {
6969
Tags.HTTP_RESPONSE_STATUS_CODE.set(span, response.getStatus());
7070
if (response.getStatus() >= 400) {
7171
span.errorOccurred();

0 commit comments

Comments
 (0)