Skip to content

Commit 95a296e

Browse files
authored
Let Spring Boot manage logback (matched) - clears 4 logback-core CVE alerts (#13916)
#13913 pinned logback-classic to 1.2.13 while Spring Boot kept logback-core at 1.2.6 (mismatch -> NoSuchMethodError -> lua e2e hang). #13915 fixed the hang by adding an explicit logback-core 1.2.13 dep, but that made Dependabot flag logback-core (4 CVEs patched only in logback 1.3.x/1.5.x, which need SLF4J 2.0 / Java 17 - unreachable on this Java-8 / Spring Boot 2.5 fixture). Drop the explicit logback pins entirely and let spring-boot-dependencies manage both logback-classic and logback-core to the same version (1.2.6). Matched versions never trigger the NoSuchMethodError, and a BOM-managed (not declared) logback-core is not flagged by Dependabot - so the 4 alerts clear without shipping a vulnerable declared dependency, and the lua fix is preserved.
1 parent 277f19b commit 95a296e

1 file changed

Lines changed: 6 additions & 13 deletions

File tree

  • test/e2e-v2/java-test-service/e2e-service-provider

test/e2e-v2/java-test-service/e2e-service-provider/pom.xml

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535

3636
<properties>
3737
<log4j2.version>2.25.4</log4j2.version>
38-
<logback.version>1.2.13</logback.version>
3938
</properties>
4039

4140
<dependencies>
@@ -75,20 +74,14 @@
7574
<version>${log4j2.version}</version>
7675
</dependency>
7776
<dependency>
77+
<!-- No explicit version: let spring-boot-dependencies manage BOTH
78+
logback-classic and logback-core to the same version so they never
79+
mismatch. A classic newer than the managed core makes logback-classic's
80+
ThrowableProxy call OptionHelper.isNotEmtpy() (absent in the older core),
81+
throwing NoSuchMethodError when logging an exception. Java 8 / Spring
82+
Boot 2.x keeps this on the logback 1.2.x line. -->
7883
<groupId>ch.qos.logback</groupId>
7984
<artifactId>logback-classic</artifactId>
80-
<version>${logback.version}</version>
81-
</dependency>
82-
<dependency>
83-
<!-- Pin logback-core to the same version as logback-classic. Spring Boot's
84-
dependency management otherwise holds logback-core at an older version
85-
(1.2.6), and logback-classic 1.2.13's ThrowableProxy calls
86-
OptionHelper.isNotEmtpy() which only exists in the matching core, so
87-
logging any exception throws NoSuchMethodError and kills the request
88-
thread. -->
89-
<groupId>ch.qos.logback</groupId>
90-
<artifactId>logback-core</artifactId>
91-
<version>${logback.version}</version>
9285
</dependency>
9386
<dependency>
9487
<groupId>org.apache.skywalking</groupId>

0 commit comments

Comments
 (0)