SOLR-18289: Build: upgrade Gradle to 9.6.0 (#4539)

- `gradle-wrapper.properties`, `libs.versions.toml` — bump Gradle 8.10 → 9.6.0;
  Lucene already completed this same migration, making the path well-trodden
- `globals.gradle`, `changes-to-html.gradle`, `check-broken-links.gradle`,
  `javacc.gradle`, `docker/build.gradle` — `Project.exec`/`javaexec` removed in
  Gradle 9; inject `ExecOperations` via holder pattern (same approach already used
  in `globals.gradle`); docker tasks use minimal injection to avoid script-local
  scoping issues with typed task classes
- `gradle-archives.gradle`, `jar-manifest.gradle`, `javac.gradle`,
  `packaging.gradle`, `defaults-maven.gradle`, `build.gradle`, `jwt-auth/build.gradle`
  — remaining Gradle 9 API migrations: `archivesBaseName` → `base { archivesName }`,
  `sourceCompatibility`/`targetCompatibility` under `java {}`, archive/copy file
  modes → `dirPermissions`/`filePermissions`, `dependencyProject` → `project(dep.path)`,
  drop forbidden `setCanBeConsumed(true)` on resolvable config, `webAppDirName` →
  `from("web")`
- `rat-sources.gradle` — resolve RAT classpath at configuration time; Gradle 9
  forbids configuration resolution at execution time; also add explicit
  `import groovy.xml.XmlParser` for Groovy 4 compatibility
- `render-javadoc.gradle` — make `findRenderTasksInDependencies()` non-private;
  Groovy 4 dispatch on decorated task instances requires it
- `dependency-analyze.gradle` — removed; `ca.cutterslade.analyze` has no
  Gradle-9-compatible release and produces false-positive failures with dependency
  locking; adopting a replacement is a separate follow-up (matches Lucene main)
- `netty-tcnative-*` license sha1 files — align pin 2.0.75 → 2.0.77 to match
  version forced by the netty BOM, resolving the two-version conflict

Author: serhiy-bzhezytskyy

build.gradle

@@ -23,7 +23,6 @@ plugins {
   id 'solr.build-infra'
 
   alias(libs.plugins.owasp.dependencycheck)
-  alias(libs.plugins.cutterslade.analyze)
   alias(libs.plugins.benmanes.versions)
   alias(libs.plugins.kotlin.multiplatform) apply false
   alias(libs.plugins.littlerobots.versioncatalogupdate) apply false
@@ -173,7 +172,6 @@ apply from: file('gradle/validation/git-status.gradle')
 apply from: file('gradle/validation/validate-source-patterns.gradle')
 apply from: file('gradle/validation/rat-sources.gradle')
 apply from: file('gradle/validation/owasp-dependency-check.gradle')
-apply from: file('gradle/validation/dependency-analyze.gradle')
 apply from: file('gradle/validation/ecj-lint.gradle')
 apply from: file('gradle/validation/gradlew-scripts-tweaked.gradle')
 apply from: file('gradle/validation/validate-log-calls.gradle')

changelog/unreleased/SOLR-18289-gradle-9.yml

@@ -0,0 +1,8 @@
+# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc
+title: The build now uses Gradle 9.6.0 (upgraded from 8.10).
+type: other
+authors:
+  - name: Serhiy Bzhezytskyy
+links:
+  - name: SOLR-18289
+    url: https://issues.apache.org/jira/browse/SOLR-18289

gradle.lockfile

@@ -1,6 +1,7 @@
 # This is a Gradle generated file for dependency locking.
 # Manual edits can break the build and are not advised.
 # This file is expected to be part of source control.
+# To regenerate this file, run: ./gradlew :dependencies --write-locks
 commons-cli:commons-cli:1.5.0=ratDeps
 commons-io:commons-io:2.11.0=ratDeps
 junit:junit:3.8.1=javacc

gradle/documentation/changes-to-html.gradle

@@ -15,6 +15,9 @@
  * limitations under the License.
  */
 
+import org.gradle.process.ExecOperations
+import javax.inject.Inject
+
 def resources = scriptResources(buildscript)
 
 configure(project(':solr:documentation')) {
@@ -37,7 +40,10 @@ configure(project(':solr:documentation')) {
 }
 
 // compile CHANGELOG.md into an html file
-class ChangesToHtmlTask extends DefaultTask {
+abstract class ChangesToHtmlTask extends DefaultTask {
+
+  @Inject
+  abstract ExecOperations getExecOperations()
 
   @Internal
   Project productProject = project.parent
@@ -67,7 +73,7 @@ class ChangesToHtmlTask extends DefaultTask {
       return
     }
 
-    def result = project.exec {
+    def result = execOperations.exec {
       executable "python3"
       standardOutput project.file("${targetDir.get().getAsFile()}/Changes.html").newOutputStream()
       errorOutput = output

gradle/documentation/render-javadoc.gradle

@@ -196,7 +196,7 @@ configure(subprojects) {
       task
           .project
           .configurations.implementation.allDependencies.withType(ProjectDependency).collect {dep ->
-        def otherProject = dep.dependencyProject
+        def otherProject = task.project.project(dep.path)
         return otherProject.tasks.findByName(task.name)
       }.findAll {
         // Do not depend on disabled tasks or tasks that do not exist
@@ -294,7 +294,7 @@ class RenderJavadocTask extends DefaultTask {
   File taskResources
 
   /** Utility method to recursively collect all tasks with same name like this one that we depend on */
-  private Set findRenderTasksInDependencies() {
+  Set findRenderTasksInDependencies() {
     Set found = []
     def collectDeps
     collectDeps = {task ->

gradle/generation/javacc.gradle

@@ -1,4 +1,6 @@
 import java.nio.charset.Charset
+import org.gradle.process.ExecOperations
+import javax.inject.Inject
 
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more
@@ -116,7 +118,10 @@ configure(project(":solr:core")) {
 }
 
 // We always regenerate, no need to declare outputs.
-class JavaCCTask extends DefaultTask {
+abstract class JavaCCTask extends DefaultTask {
+  @Inject
+  abstract ExecOperations getExecOperations()
+
   @InputFile
   File javaccFile
 
@@ -164,7 +169,7 @@ class JavaCCTask extends DefaultTask {
     logger.lifecycle("Recompiling JavaCC: ${project.rootDir.relativePath(javaccFile)}")
 
     def output = new ByteArrayOutputStream()
-    def result = project.javaexec {
+    def result = execOperations.javaexec {
       classpath {
         project.rootProject.configurations.javacc
       }

gradle/globals.gradle

@@ -15,6 +15,14 @@
  * limitations under the License.
  */
 
+import javax.inject.Inject
+import org.gradle.process.ExecOperations
+
+interface ExecOperationsHolder {
+  @Inject
+  ExecOperations getExecOperations()
+}
+
 allprojects {
   apply plugin: 'base'
 
@@ -35,10 +43,12 @@ allprojects {
 
   // Artifacts will have names after full gradle project path
   // so :solr:core will have solr-core.jar, etc.
-  project.archivesBaseName = project.path
-      .replaceAll("^:", "")
-      .replace(':', '-')
-      .replace("-modules-", "-")
+  project.base {
+    archivesName = project.path
+        .replaceAll("^:", "")
+        .replace(':', '-')
+        .replace("-modules-", "-")
+  }
 
   project.ext {
     // Utility method to support passing overrides via -P or -D.
@@ -110,7 +120,8 @@ allprojects {
           }
         }
 
-        result = project.exec {ExecSpec execSpec ->
+        def execOps = project.objects.newInstance(ExecOperationsHolder).execOperations
+        result = execOps.exec {ExecSpec execSpec ->
           project.configure(execSpec, closure)
 
           saveIgnoreExitValue = execSpec.ignoreExitValue

gradle/hacks/gradle-archives.gradle

@@ -20,7 +20,7 @@ allprojects {
   tasks.withType(AbstractArchiveTask).configureEach {task ->
     duplicatesStrategy = DuplicatesStrategy.FAIL
     reproducibleFileOrder = true
-    dirMode = 0755
-    fileMode = 0644
+    dirPermissions { unix("0755") }
+    filePermissions { unix("0644") }
   }
 }

gradle/java/jar-manifest.gradle

@@ -63,8 +63,8 @@ subprojects {
               "Specification-Title": title,
 
               // Evaluate these properties lazily so that the defaults are applied properly.
-              "X-Compile-Source-JDK": "${-> project.sourceCompatibility}",
-              "X-Compile-Target-JDK": "${-> project.targetCompatibility}",
+              "X-Compile-Source-JDK": "${-> project.java.sourceCompatibility}",
+              "X-Compile-Target-JDK": "${-> project.java.targetCompatibility}",
 
               "X-Build-JDK": "${System.properties['java.version']} (${System.properties['java.vendor']} ${System.properties['java.vm.version']})",
               "X-Build-OS": "${System.properties['os.name']} ${System.properties['os.arch']} ${System.properties['os.version']}"

gradle/java/javac.gradle

@@ -19,8 +19,10 @@
 
 allprojects {
   plugins.withType(JavaPlugin) {
-    sourceCompatibility = project.minJavaVersion
-    targetCompatibility = project.minJavaVersion
+    java {
+      sourceCompatibility = project.minJavaVersion
+      targetCompatibility = project.minJavaVersion
+    }
     // Use 'release' flag instead of 'source' and 'target'
     tasks.withType(JavaCompile) {
       compileTestJava {