SOLR-18296: reformat with google-java-format 1.35.0

Pure mechanical reformatting from running ./gradlew tidy with the upgraded
formatter. No logic changes. This commit's SHA is added to
.git-blame-ignore-revs (in a follow-up) so git blame skips it.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: serhiy-bzhezytskyy

CHANGELOG.md

@@ -230,8 +230,8 @@ private void check(Element element) {
       case PACKAGE:
         checkComment(element);
         break;
-        // class-like elements, check them, then recursively check their children (fields and
-        // methods)
+      // class-like elements, check them, then recursively check their children (fields and
+      // methods)
       case CLASS:
       case INTERFACE:
       case ENUM:
@@ -251,7 +251,7 @@ private void check(Element element) {
           }
         }
         break;
-        // method-like elements, check them if we are configured to do so
+      // method-like elements, check them if we are configured to do so
       case METHOD:
       case CONSTRUCTOR:
       case FIELD:

build-tools/missing-doclet/src/main/java/org/apache/lucene/missingdoclet/MissingDoclet.java

@@ -287,7 +287,7 @@
 - Remove obsolete overseer internal work queue. This queue was read-only since Solr 8. [SOLR-17929](https://issues.apache.org/jira/browse/SOLR-17929) (Pierre Salagnac)
 - Raising the per ramPerThreadHardLimit to be configurable >2GB [SOLR-17942](https://issues.apache.org/jira/browse/SOLR-17942) (Puneet Ahuja)
 - Removed TikaLanguageIdentifierUpdateProcessor. Use LangDetectLanguageIdentifierUpdateProcessor or OpenNLPLangDetectUpdateProcessor instead. [SOLR-17960](https://issues.apache.org/jira/browse/SOLR-17960) (janhoy)
-- The deprecated SolrClient implementations based on Apache HttpClient are removed from Solrj, thus the related dependencies are no longer present. They temporarily live on in the test framework. #17962 [SOLR-17962](https://issues.apache.org/jira/browse/SOLR-17962) (David Smiley)
+- The deprecated SolrClient implementations based on Apache HttpClient are removed from Solrj, thus the related dependencies are no longer present. They temporarily live on in the test framework in different packages & names. #17962 [SOLR-17962](https://issues.apache.org/jira/browse/SOLR-17962) (David Smiley)
 - These SolrCloud commands no longer aquire locks (waiting or blocking on other commands that do): COLLECTIONPROP, ADDREPLICAPROP, DELETEREPLICAPROP. [SOLR-17963](https://issues.apache.org/jira/browse/SOLR-17963) (David Smiley)
 - Rename HttpClientBuilderFactory to SolrClientCustomizer, and property solr.httpclient.builder.factory to solr.solrj.http.jetty.customizer [SOLR-17994](https://issues.apache.org/jira/browse/SOLR-17994) (David Smiley)
 - New SolrJ SolrRequest.processWithBaseUrl, new HttpSolrClientBase.requestWithBaseUrl. Existing callers will require updates due to a signature change. [SOLR-17996](https://issues.apache.org/jira/browse/SOLR-17996) (David Smiley)

changelog/v10.0.0/version-summary.md

@@ -323,21 +323,21 @@ boolean useReadCache(String name, IOContext context) {
       return false;
     }
     switch (context.context()) {
-        // depending on params, we don't cache on merges or when only reading once
+      // depending on params, we don't cache on merges or when only reading once
       case MERGE:
         {
           return cacheMerges;
         }
-        /* TODO
-        case READ:
-          {
-            if (context.readOnce) {
-              return cacheReadOnce;
-            } else {
-              return true;
-            }
+      /* TODO
+      case READ:
+        {
+          if (context.readOnce) {
+            return cacheReadOnce;
+          } else {
+            return true;
           }
-          */
+        }
+        */
       default:
         {
           return true;

solr/core/src/java/org/apache/solr/blockcache/BlockDirectory.java

@@ -279,7 +279,7 @@ SolrInputDocument readDocument(XMLStreamReader reader, IndexSchema schema)
     while (true) {
       int event = reader.next();
       switch (event) {
-          // Add everything to the text
+        // Add everything to the text
         case XMLStreamConstants.SPACE:
         case XMLStreamConstants.CDATA:
         case XMLStreamConstants.CHARACTERS:

solr/core/src/java/org/apache/solr/handler/DocumentAnalysisRequestHandler.java

@@ -275,8 +275,9 @@ private BackupStats incrementalCopy(Collection<String> indexFiles, Directory dir
         case Error err -> throw err;
         case IOException ioe -> throw ioe;
         case RuntimeException re -> throw re;
-        default -> throw new SolrException(
-            SolrException.ErrorCode.UNKNOWN, "Error during parallel backup upload", cause);
+        default ->
+            throw new SolrException(
+                SolrException.ErrorCode.UNKNOWN, "Error during parallel backup upload", cause);
       }
     } catch (InterruptedException e) {
       uploadFutures.forEach(f -> f.cancel(true));

solr/core/src/java/org/apache/solr/handler/IncrementalShardBackup.java

@@ -195,8 +195,9 @@ public boolean doRestore() throws Exception {
           case Error err -> throw err;
           case IOException ioe -> throw ioe;
           case RuntimeException re -> throw re;
-          default -> throw new SolrException(
-              SolrException.ErrorCode.UNKNOWN, "Error during parallel restore download", cause);
+          default ->
+              throw new SolrException(
+                  SolrException.ErrorCode.UNKNOWN, "Error during parallel restore download", cause);
         }
       } catch (InterruptedException e) {
         downloadFutures.forEach(f -> f.cancel(true));

solr/core/src/java/org/apache/solr/handler/RestoreCore.java

@@ -461,9 +461,10 @@ private FilterType extractFilterType(SolrParams params) {
         case "none" -> FilterType.none;
         case "name" -> FilterType.name;
         case "status" -> FilterType.status;
-        default -> throw new SolrException(
-            ErrorCode.BAD_REQUEST,
-            "Invalid filterType '" + filterType + "'. Allowed values are: none, name, status");
+        default ->
+            throw new SolrException(
+                ErrorCode.BAD_REQUEST,
+                "Invalid filterType '" + filterType + "'. Allowed values are: none, name, status");
       };
     }
     return FilterType.none;

solr/core/src/java/org/apache/solr/handler/admin/ZookeeperInfoHandler.java

@@ -145,8 +145,9 @@ public static PivotFacetValue createFromNamedList(
         case STATS -> statsValues = (NamedList<NamedList<NamedList<?>>>) value;
         case QUERIES -> queryCounts = (NamedList<Number>) value;
         case RANGES -> ranges = (SimpleOrderedMap<SimpleOrderedMap<Object>>) value;
-        default -> throw new RuntimeException(
-            "PivotListEntry contains unaccounted for item: " + pivotEntry);
+        default ->
+            throw new RuntimeException(
+                "PivotListEntry contains unaccounted for item: " + pivotEntry);
       }
     }
 

solr/core/src/java/org/apache/solr/handler/component/PivotFacetValue.java

@@ -768,7 +768,7 @@ protected String stageToString(int stage) {
         return "EXECUTE_QUERY";
       case STAGE_GET_FIELDS:
         return "GET_FIELDS";
-        // nobody wants to think it was DONE and canceled after it completed...
+      // nobody wants to think it was DONE and canceled after it completed...
       case STAGE_DONE:
         return "FINISHING";
       default: