SOLR-18181: ValueSourceAugmenter NPE when rows exceed 1000 and scores requested#4314
Merged
mlbiscoc merged 2 commits intoapache:branch_9xfrom Apr 23, 2026
Merged
SOLR-18181: ValueSourceAugmenter NPE when rows exceed 1000 and scores requested#4314mlbiscoc merged 2 commits intoapache:branch_9xfrom
mlbiscoc merged 2 commits intoapache:branch_9xfrom
Conversation
HoustonPutman
approved these changes
Apr 21, 2026
Contributor
HoustonPutman
left a comment
HoustonPutman
left a comment
There was a problem hiding this comment.
Looks good, the change is already there in 10x, so this is just bringing 9x more in-line.
dsmiley
reviewed
Apr 24, 2026
| @@ -0,0 +1,7 @@ | |||
| title: Fix NPE in ValueSourceAugmenter when rows exceed prefetch limit with scores requested | |||
Contributor
There was a problem hiding this comment.
End users (who generally aren't Solr hackers) have no idea what ValueSourceAugmenter even is; it's an internal thing. They do know about use of function queries in the "fl". In the changelog we should try to explain the impact when we can, like:
Use of function queries in "fl" would fail if rows exceeds 1000 and scores requested. A regression since v9.9.
Here, users would then see this for the serious regression that this is:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to send a query with ValueSourceAugmenter that requested score and > 1000 rows resulted in an NPE. This is because when it passes prefetch limit and tries to retrieve score, it was referenced incorrectly.
ValueSourceAugmenter was overriding a deprecated 2-arg method which didn't have access to score. The method then incorrectly tried to get score via
(float) doc.get("score")To fix, we override the non-deprecated method instead which actually has
DocIterationInfoto get the score.