SOLR-18206 Use google-cloud-bom instead of individual lib pinning#4323
Merged
Conversation
Remove explicit version declarations for libs covered by the bom
Add consistendResolution.useCompileClasspathVersions
janhoy
commented
Apr 23, 2026
janhoy
commented
Apr 23, 2026
| # @keep transitive dependency for version alignment | ||
| grpc-core = { module = "io.grpc:grpc-core", version.ref = "grpc" } | ||
| grpc-netty = { module = "io.grpc:grpc-netty", version.ref = "grpc" } | ||
| grpc-protobuf = { module = "io.grpc:grpc-protobuf", version.ref = "grpc" } |
Contributor
Author
There was a problem hiding this comment.
We should probably try the same trick (removing version.ref) for the grpc-* family as well, although they use a common version.
Contributor
Author
|
Crave tests failed with Have anyone seen it before? Could it be the build cancellations in #4318 that is not working as it should and leaves behind old workspaces? Who has the foo to clean up? |
Contributor
Author
|
There was some review and discussion on the original #4098 PR. Anything more to add? I intend to merge this to main and 10_x on Wednesday. |
malliaridis
approved these changes
May 11, 2026
malliaridis
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Only one note for 10.x, there are 1-2 dependencies with major upgrade (google-http-client* from 1.x to 2.x). If that is fine for 10.x, feel free to proceed with the backport. :)
janhoy
added a commit
that referenced
this pull request
May 13, 2026
) (cherry picked from commit 20fe771)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18206
This PR supersedes #4098 (originally opened by Renovate/SolrBot) and expands its scope significantly.
Instead of just bumping individual Google Cloud library versions, this PR switches the GCS repository module to resolve all Google Cloud dependencies via the
google-cloud-bomBill of Materials, then bumps the BOM to the latest version (0.261.0). This simplifies future upgrades — only the BOM version needs updating, and all transitive Google Cloudlibraries are automatically aligned.
Changes
google-cloud-bombumped from0.224.0→0.261.0grpc-bombumped from1.65.1→1.80.0google-cloud-storage,google-cloud-nio,google-cloud-core,google-cloud-core-http,google-auth,google-api-gax)consistentResolution.useCompileClasspathVersions()to the GCS module to align dependency resolution across configurationsKey transitive version changes (via BOM 0.261.0)
google-cloud-storagegoogle-cloud-niogoogle-cloud-coregoogle-authgaxgrpc-*Closes #3117