Exclude some files from the source release.#4551
Open
dsmiley wants to merge 1 commit into
Open
Conversation
Thus avoiding ASF requirements for such files to have source headers.
Contributor
Author
|
I could remove some headers here as well... but that snowballs to manipulating RAT config... well okay I could. Ideally IMO RAT runs at smoketester phase. |
dsmiley
commented
Jun 26, 2026
| # in_root_folder.remove(fileName) | ||
|
|
||
| if isSrc: | ||
| expected_src_root_folders = ['build-tools', 'changelog', 'dev-docs', 'dev-tools', 'gradle', 'solr'] |
Contributor
Author
There was a problem hiding this comment.
dunno why we check for "expected" source root folders at all.
Contributor
There was a problem hiding this comment.
As I remember, mainly to assert that nothing new unexpected has crept in. A nice extra explicit assertion on what we intend to ship.
Contributor
Author
There was a problem hiding this comment.
I think that's an obsolete concern, and we should remove this check altogether. Perhaps long ago the source release was built manually and had risk of including temp/junk but the process today is from what's committed to source control (not the working tree).
janhoy
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thus avoiding ASF requirements for such files to have source headers.
Deferring header removal to a follow-up.
To know if this truly breaks anything, we'll sadly need to wait for the smoketester, as we have no PR invokable smoketest validation workflow/task nor a way to run it locally in my experience. My attempts to run it locally a couple months ago kept turning up one problem after another.