[SPARK-54999] Re-enable ConstraintTests by moving into IcebergTests#401
Draft
dongjoon-hyun wants to merge 1 commit into
Draft
[SPARK-54999] Re-enable ConstraintTests by moving into IcebergTests#401dongjoon-hyun wants to merge 1 commit into
ConstraintTests by moving into IcebergTests#401dongjoon-hyun wants to merge 1 commit into
Conversation
dongjoon-hyun
marked this pull request as draft
May 29, 2026 20:20
Member
Author
|
This is still a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR re-enables the constraint test coverage (SPARK-51207, SPIP: Constraints in DSv2) that was disabled in SPARK-54998, by moving the four tests out of the disabled
ConstraintTestssuite intoIcebergTestsand switching them fromUSING ORC(DSv1) toUSING ICEBERG(DSv2):primary_key,foreign_key,unique, andchecknow createlocal.db.*Iceberg tables and run under the existingSPARK_ICEBERG_TEST_ENABLEDguard, like the otherIcebergTests.spark.version.starts(with: "4.1")guard is kept so the constraint syntax (a Spark 4.1+ feature) runs only on the Spark4.1.2Iceberg CI job and is skipped on the Spark4.0.2one.Tests/SparkConnectTests/ConstraintTests.swiftis removed.foreign_keytest to reference the parent table (tableName1, which hasid) instead of the table being created.Note that this is possible because we moved to Apache Iceberg 1.11.0.
Icebergto 1.11.0 in integration tests #376Why are the changes needed?
ConstraintTestswas disabled in SPARK-54998 because Spark 4.1.1+ started throwing on constraint syntax for DSv1 (ORC) tables after SPARK-54761, and the original plan was to revisit this with DSv2 tables once Apache Iceberg supported Spark 4.1. Iceberg now ships a Spark 4.1 runtime (iceberg-spark-runtime-4.1_2.13:1.11.0, already used by CI), so the constraint syntax can be validated against DSv2/Iceberg tables as originally intended.Does this PR introduce any user-facing change?
No. This is a test-only change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)