Skip to content

Commit eb2f9d4

Browse files
committed
[SPARK-57402][SQL] Use named parameters when constructing AUTO CDC case classes
Convert the positional AutoCdcIntoCommand and AutoCdcParams constructions in AstBuilder.parseAutoCdcParams/buildAutoCdcIntoCommand to named parameters. No behavior change. Co-authored-by: Isaac
1 parent 0ddd1f1 commit eb2f9d4

1 file changed

Lines changed: 14 additions & 8 deletions

File tree

  • sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1367,13 +1367,13 @@ class AstBuilder extends DataTypeAstBuilder
13671367
val target = visitMultipartIdentifier(ctx.target).asTableIdentifier
13681368
val params = parseAutoCdcParams(ctx.autoCdcParameters())
13691369
AutoCdcIntoCommand(
1370-
target,
1371-
params.source,
1372-
params.keys,
1373-
params.deleteCondition,
1374-
params.sequencing,
1375-
params.includeColumns,
1376-
params.excludeColumns)
1370+
targetTable = target,
1371+
source = params.source,
1372+
keys = params.keys,
1373+
deleteCondition = params.deleteCondition,
1374+
sequenceByExpr = params.sequencing,
1375+
includeColumns = params.includeColumns,
1376+
excludeColumns = params.excludeColumns)
13771377
}
13781378

13791379
protected def parseAutoCdcParams(params: AutoCdcParametersContext): AutoCdcParams =
@@ -1394,7 +1394,13 @@ class AstBuilder extends DataTypeAstBuilder
13941394
visitIdentifierSeq(c.exceptCols).map(UnresolvedAttribute.quoted)
13951395
}
13961396

1397-
AutoCdcParams(source, keys, deleteCondition, sequencing, includeColumns, excludeColumns)
1397+
AutoCdcParams(
1398+
source = source,
1399+
keys = keys,
1400+
deleteCondition = deleteCondition,
1401+
sequencing = sequencing,
1402+
includeColumns = includeColumns,
1403+
excludeColumns = excludeColumns)
13981404
}
13991405

14001406
/**

0 commit comments

Comments
 (0)