[SPARK-56372][INFRA] Add cmake to CI Docker images for R fs package compilation#55233
Closed
zhengruifeng wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-56372][INFRA] Add cmake to CI Docker images for R fs package compilation#55233zhengruifeng wants to merge 2 commits intoapache:masterfrom
zhengruifeng wants to merge 2 commits intoapache:masterfrom
Conversation
…ompilation The R `fs` package now bundles libuv v1.52.0 which requires cmake to build. This caused the base image build to fail in CI. Co-authored-by: Isaac
Co-authored-by: Isaac
zhengruifeng
commented
Apr 7, 2026
| 'pytest==7.1.3' \ | ||
| 'scipy>=1.8.0' \ | ||
| 'scipy-stubs' \ | ||
| 'types-protobuf==6.32.1.20260221' \ |
Contributor
Author
There was a problem hiding this comment.
the refresh of image will upgrade types-protobuf to 7.34.1.20260403 and fails linter https://github.com/zhengruifeng/spark/actions/runs/24069019701/job/70214055939
LuciferYang
approved these changes
Apr 7, 2026
This was referenced Apr 7, 2026
HyukjinKwon
approved these changes
Apr 7, 2026
Member
|
Merged to master. Can we create backports to other branches? |
zhengruifeng
added a commit
to zhengruifeng/spark
that referenced
this pull request
Apr 8, 2026
…ompilation Add `cmake` to the `apt-get install` list in CI Docker images (`docs`, `lint`, `sparkr`). The R `fs` package (a transitive dependency of `devtools`, `testthat`, `rmarkdown`) now bundles `libuv v1.52.0`, which requires `cmake` to build. This causes the "Base image build" job to fail with: ``` /bin/bash: line 2: cmake: command not found make: *** [Makevars:44: libuv] Error 127 ERROR: compilation failed for package 'fs' ``` The `fs` compilation failure cascades into: `sass` → `bslib` → `shiny` → `rmarkdown` → `devtools` → `testthat`, breaking the entire R package installation. See https://github.com/apache/spark/actions/runs/24067715329/job/70197367201 No. CI should pass with the updated Docker images. Co-authored-by: Claude code (Opus 4.6) Closes apache#55233 from zhengruifeng/fix_imsage. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
zhengruifeng
added a commit
to zhengruifeng/spark
that referenced
this pull request
Apr 8, 2026
…ompilation Add `cmake` to the `apt-get install` list in CI Docker images (`docs`, `lint`, `sparkr`). The R `fs` package (a transitive dependency of `devtools`, `testthat`, `rmarkdown`) now bundles `libuv v1.52.0`, which requires `cmake` to build. This causes the "Base image build" job to fail with: ``` /bin/bash: line 2: cmake: command not found make: *** [Makevars:44: libuv] Error 127 ERROR: compilation failed for package 'fs' ``` The `fs` compilation failure cascades into: `sass` → `bslib` → `shiny` → `rmarkdown` → `devtools` → `testthat`, breaking the entire R package installation. See https://github.com/apache/spark/actions/runs/24067715329/job/70197367201 No. CI should pass with the updated Docker images. Co-authored-by: Claude code (Opus 4.6) Closes apache#55233 from zhengruifeng/fix_imsage. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
added a commit
that referenced
this pull request
Apr 16, 2026
### What changes were proposed in this pull request? Replaces `devtools` to `remotes` which is lighter. It does not fix CRAN related because we don't release on CRAN anymore. ### Why are the changes needed? - A lot of usages of `devtools` in our repo is actually deprecated. - Causes many issues like #55216 #55233 #55245 - It fails again because it requires another dependency. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Will minotior the CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #55362 from HyukjinKwon/SPARK-56500. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
added a commit
that referenced
this pull request
Apr 16, 2026
Replaces `devtools` to `remotes` which is lighter. It does not fix CRAN related because we don't release on CRAN anymore. - A lot of usages of `devtools` in our repo is actually deprecated. - Causes many issues like #55216 #55233 #55245 - It fails again because it requires another dependency. No, dev-only. Will minotior the CI. No. Closes #55362 from HyukjinKwon/SPARK-56500. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
added a commit
that referenced
this pull request
Apr 16, 2026
Replaces `devtools` to `remotes` which is lighter. It does not fix CRAN related because we don't release on CRAN anymore. - A lot of usages of `devtools` in our repo is actually deprecated. - Causes many issues like #55216 #55233 #55245 - It fails again because it requires another dependency. No, dev-only. Will minotior the CI. No. Closes #55362 from HyukjinKwon/SPARK-56500. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 84e6954) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
added a commit
that referenced
this pull request
Apr 16, 2026
Replaces `devtools` to `remotes` which is lighter. It does not fix CRAN related because we don't release on CRAN anymore. - A lot of usages of `devtools` in our repo is actually deprecated. - Causes many issues like #55216 #55233 #55245 - It fails again because it requires another dependency. No, dev-only. Will minotior the CI. No. Closes #55362 from HyukjinKwon/SPARK-56500. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 84e6954) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
cmaketo theapt-get installlist in CI Docker images (docs,lint,sparkr).Why are the changes needed?
The R
fspackage (a transitive dependency ofdevtools,testthat,rmarkdown) now bundleslibuv v1.52.0, which requirescmaketo build. This causes the "Base image build" job to fail with:The
fscompilation failure cascades into:sass→bslib→shiny→rmarkdown→devtools→testthat, breaking the entire R package installation.See https://github.com/apache/spark/actions/runs/24067715329/job/70197367201
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI should pass with the updated Docker images.
Was this patch authored or co-authored using generative AI tooling?
Co-authored-by: Claude code (Opus 4.6)