[DO-NOT-MERGE][SPARK-56692][INFRA] Check release date of upgrade of pom dependency#55641
Draft
gaogaotiantian wants to merge 4 commits intoapache:masterfrom
Draft
[DO-NOT-MERGE][SPARK-56692][INFRA] Check release date of upgrade of pom dependency#55641gaogaotiantian wants to merge 4 commits intoapache:masterfrom
gaogaotiantian wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Great, the CI failed like blood - https://github.com/gaogaotiantian/spark/actions/runs/25196166947/job/73877257920 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
According to our discussion in dev channel, we want to have a 7-day buffer time between a certain 3rd party package is released and we upgrade the dependency. This is the CI check to prevent PRs that break the policy.
Basically if
pom.xmlis modified, the test script will search for the upgraded version, then check the maven registry about it's modified time, then raise an exception if it's too early.Why are the changes needed?
To prevent accidentally upgraded dependencies.
Does this PR introduce any user-facing change?
No, it's infra only.
How was this patch tested?
Locally tested that it works. I intentionally upgraded
fasterxml.jacksonwhich was released 2 days ago - the CI should be able to catch it.It also means this PR should not be merged before this change is reverted.
Was this patch authored or co-authored using generative AI tooling?
No.