[SPARK-56882][SDP] Implement SCD1 Batch Processor; Target Column Projection#55991
Closed
AnishMahto wants to merge 4 commits into
Closed
[SPARK-56882][SDP] Implement SCD1 Batch Processor; Target Column Projection#55991AnishMahto wants to merge 4 commits into
AnishMahto wants to merge 4 commits into
Conversation
szehon-ho
reviewed
May 21, 2026
Member
szehon-ho
left a comment
szehon-ho
left a comment
There was a problem hiding this comment.
LGTM on the incremental projectTargetColumnsOntoMicrobatch change. Left one design question, a comment typo nit, and a few suggested tests inline.
| ColumnSelection.applyToSchema( | ||
| schemaName = "microbatch", | ||
| schema = userColumnsInMicrobatchSchema, | ||
| columnSelection = changeArgs.columnSelection, |
Member
There was a problem hiding this comment.
Question: columnSelection can remove key columns (e.g. ExcludeColumns on a key, or a narrow IncludeColumns that omits keys). Will a later merge step still need those columns on this DataFrame?
If keys must remain until after merge, we should validate here (or when constructing ChangeArgs) that changeArgs.keys are not dropped. If merge runs before projection, or keys are re-injected elsewhere, could you add a brief note in the scaladoc on the expected pipeline order?
Contributor
Author
There was a problem hiding this comment.
Yep we do require all keys remain in the column selection.
I added that validation in this PR during flow analysis time (well before flow execution, which is when this would actually be called) - see requireKeysPresentInSelectedSchema.
Flow analysis must always be done before flow execution, so there's no need to do additional user-friendly validation in this internal flow execution step. For unit testing purposes if a test is incorrectly setup, spark will just throw an unresolved column exception.
AnishMahto
force-pushed
the
SPARK-56882-SCD1-project-target-columns-onto-microbatch
branch
from
1be3cba to
0660d8d
Compare
AnishMahto
force-pushed
the
SPARK-56882-SCD1-project-target-columns-onto-microbatch
branch
from
0660d8d to
b71ec8e
Compare
AnishMahto
force-pushed
the
SPARK-56882-SCD1-project-target-columns-onto-microbatch
branch
from
b71ec8e to
e53bcf4
Compare
szehon-ho
approved these changes
May 22, 2026
dbtsai
pushed a commit
that referenced
this pull request
May 22, 2026
…ection Approved AutoCDC SPIP: https://lists.apache.org/thread/j6sj9wo9odgdpgzlxtvhoy7szs0jplf7 -------- **Preamble:** The SCD type 1 flow is a foreachBatch streaming query on an input change-data-feed, and is responsible for reconciling the incoming change data onto some target table that follows SCD1 replication semantics. SCD1 flows also maintain an "auxiliary" table to keep track of early-arriving out-of-order received events state. Each microbatch will need to reconcile against this auxiliary table as well, and update the auxiliary table's state appropriately for future microbatches. **Target Column Projection:** As per the SPIP and `ChangeArgs.columnSelection`, users are allowed to specify the set of columns that actually gets persisted in the target table. Any columns not selected should be dropped before target table merge/persistence. We should project only these selected columns onto the microbatch so that its dataframe is in the correct shape prior to CDC processing and merging into the target table. Closes #55991 from AnishMahto/SPARK-56882-SCD1-project-target-columns-onto-microbatch. Authored-by: AnishMahto <anish.mahto99@gmail.com> Signed-off-by: DB Tsai <dbtsai@dbtsai.com> (cherry picked from commit af2cfc0) Signed-off-by: DB Tsai <dbtsai@dbtsai.com>
dbtsai
pushed a commit
that referenced
this pull request
May 22, 2026
…ection Approved AutoCDC SPIP: https://lists.apache.org/thread/j6sj9wo9odgdpgzlxtvhoy7szs0jplf7 -------- **Preamble:** The SCD type 1 flow is a foreachBatch streaming query on an input change-data-feed, and is responsible for reconciling the incoming change data onto some target table that follows SCD1 replication semantics. SCD1 flows also maintain an "auxiliary" table to keep track of early-arriving out-of-order received events state. Each microbatch will need to reconcile against this auxiliary table as well, and update the auxiliary table's state appropriately for future microbatches. **Target Column Projection:** As per the SPIP and `ChangeArgs.columnSelection`, users are allowed to specify the set of columns that actually gets persisted in the target table. Any columns not selected should be dropped before target table merge/persistence. We should project only these selected columns onto the microbatch so that its dataframe is in the correct shape prior to CDC processing and merging into the target table. Closes #55991 from AnishMahto/SPARK-56882-SCD1-project-target-columns-onto-microbatch. Authored-by: AnishMahto <anish.mahto99@gmail.com> Signed-off-by: DB Tsai <dbtsai@dbtsai.com> (cherry picked from commit af2cfc0) Signed-off-by: DB Tsai <dbtsai@dbtsai.com>
Member
|
Merged into master, 4.x, 4.2. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approved AutoCDC SPIP: https://lists.apache.org/thread/j6sj9wo9odgdpgzlxtvhoy7szs0jplf7
Preamble:
The SCD type 1 flow is a foreachBatch streaming query on an input change-data-feed, and is responsible for reconciling the incoming change data onto some target table that follows SCD1 replication semantics.
SCD1 flows also maintain an "auxiliary" table to keep track of early-arriving out-of-order received events state. Each microbatch will need to reconcile against this auxiliary table as well, and update the auxiliary table's state appropriately for future microbatches.
Target Column Projection:
As per the SPIP and
ChangeArgs.columnSelection, users are allowed to specify the set of columns that actually gets persisted in the target table. Any columns not selected should be dropped before target table merge/persistence.We should project only these selected columns onto the microbatch so that its dataframe is in the correct shape prior to CDC processing and merging into the target table.