Skip to content

[SPARK-50520][PySpark] Respect timeout in df.rdd.countApprox() #56060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rishav23 wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −1
Open

[SPARK-50520][PySpark] Respect timeout in df.rdd.countApprox() #56060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4984467
[SPARK-50520][PySpark] Respect timeout semantics in approximate RDD a…
rishav23 May 22, 2026
c49d15e
[SPARK-50520][PySpark] Trigger CI
rishav23 May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/pyspark/core/rdd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4843,7 +4843,8 @@ def sumApprox(
jrdd = self.mapPartitions(lambda it: [float(sum(it))])._to_java_object_rdd()
assert self.ctx._jvm is not None
jdrdd = self.ctx._jvm.JavaDoubleRDD.fromRDD(jrdd.rdd())
r = jdrdd.sumApprox(timeout, confidence).getFinalValue()
partial = jdrdd.sumApprox(timeout, confidence)
r = partial.initialValue()
return BoundedFloat(r.mean(), r.confidence(), r.low(), r.high())

def meanApprox(
Expand Down
12 changes: 12 additions & 0 deletions python/pyspark/tests/test_rdd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,18 @@ def test_distinct(self):
self.assertEqual(result.getNumPartitions(), 5)
self.assertEqual(result.count(), 3)

def test_count_approx_respects_timeout(self):
rdd = self.sc.range(1000000, numSlices=8)
start = time.time()
result = rdd.countApprox(timeout=100)
elapsed = time.time() - start
self.assertLess(elapsed, 10)
self.assertIsNotNone(result)

def test_count_approx_returns_exact_when_completed(self):
rdd = self.sc.parallelize(range(1000), 8)
self.assertEqual(rdd.countApprox(timeout=5000), 1000)

def test_external_group_by_key(self):
self.sc._conf.set("spark.python.worker.memory", "1m")
N = 2000001
Expand Down