[SPARK-57679][PYTHON] Fix numpy type checking#56757
Closed
gaogaotiantian wants to merge 4 commits into
Closed
Conversation
gaogaotiantian
changed the title
dongjoon-hyun
approved these changes
Jun 25, 2026
uros-b
approved these changes
Jun 25, 2026
uros-b
left a comment
uros-b
left a comment
Member
There was a problem hiding this comment.
Thank you @gaogaotiantian and @dongjoon-hyun!
uros-b
reviewed
Jun 25, 2026
| and len(tpe.__args__) > 1 | ||
| ): | ||
| # numpy.typing.NDArray | ||
| # numpy.typing.NDArray for numpy < 2.5 |
Member
There was a problem hiding this comment.
Suggested change
| # numpy.typing.NDArray for numpy < 2.5 | |
| # numpy.typing.NDArray for numpy < 2.5.0 |
Contributor
Author
There was a problem hiding this comment.
Technically < 2.5.0 is the same as < 2.5 I believe we check minor (instead of micro) version of numpy in another few places.
HyukjinKwon
approved these changes
Jun 25, 2026
HyukjinKwon
changed the title
gaogaotiantian
added a commit
that referenced
this pull request
Jun 30, 2026
### What changes were proposed in this pull request? Add a branch to detect `NDArray` for `numpy >= 2.5.0`. ### Why are the changes needed? Our detection for `NDArray` is a bit fragile. `numpy` changed the type alias in `2.5.0` so we need another way to detect it. CI is failing - https://github.com/apache/spark/actions/runs/28064134730/job/83087583742 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Local test passed ### Was this patch authored or co-authored using generative AI tooling? Yes, Claude Code (Opus 4.8 high) Closes #56757 from gaogaotiantian/fix-numpy-type-checking. Authored-by: Tian Gao <gaogaotiantian@hotmail.com> Signed-off-by: Tian Gao <gaogaotiantian@hotmail.com> (cherry picked from commit 5f7570c) Signed-off-by: Tian Gao <gaogaotiantian@hotmail.com>
gaogaotiantian
added a commit
that referenced
this pull request
Jun 30, 2026
Add a branch to detect `NDArray` for `numpy >= 2.5.0`. Our detection for `NDArray` is a bit fragile. `numpy` changed the type alias in `2.5.0` so we need another way to detect it. CI is failing - https://github.com/apache/spark/actions/runs/28064134730/job/83087583742 No. Local test passed Yes, Claude Code (Opus 4.8 high) Closes #56757 from gaogaotiantian/fix-numpy-type-checking. Authored-by: Tian Gao <gaogaotiantian@hotmail.com> Signed-off-by: Tian Gao <gaogaotiantian@hotmail.com> (cherry picked from commit 5f7570c) Signed-off-by: Tian Gao <gaogaotiantian@hotmail.com>
gaogaotiantian
added a commit
that referenced
this pull request
Jun 30, 2026
Add a branch to detect `NDArray` for `numpy >= 2.5.0`. Our detection for `NDArray` is a bit fragile. `numpy` changed the type alias in `2.5.0` so we need another way to detect it. CI is failing - https://github.com/apache/spark/actions/runs/28064134730/job/83087583742 No. Local test passed Yes, Claude Code (Opus 4.8 high) Closes #56757 from gaogaotiantian/fix-numpy-type-checking. Authored-by: Tian Gao <gaogaotiantian@hotmail.com> Signed-off-by: Tian Gao <gaogaotiantian@hotmail.com> (cherry picked from commit 5f7570c) Signed-off-by: Tian Gao <gaogaotiantian@hotmail.com>
gaogaotiantian
added a commit
that referenced
this pull request
Jun 30, 2026
Add a branch to detect `NDArray` for `numpy >= 2.5.0`. Our detection for `NDArray` is a bit fragile. `numpy` changed the type alias in `2.5.0` so we need another way to detect it. CI is failing - https://github.com/apache/spark/actions/runs/28064134730/job/83087583742 No. Local test passed Yes, Claude Code (Opus 4.8 high) Closes #56757 from gaogaotiantian/fix-numpy-type-checking. Authored-by: Tian Gao <gaogaotiantian@hotmail.com> Signed-off-by: Tian Gao <gaogaotiantian@hotmail.com> (cherry picked from commit 5f7570c) Signed-off-by: Tian Gao <gaogaotiantian@hotmail.com>
Contributor
Author
|
Merged to master, branch-4.x, branch-4.2, branch-4.1 and branch-4.0. Thank you all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a branch to detect
NDArrayfornumpy >= 2.5.0.Why are the changes needed?
Our detection for
NDArrayis a bit fragile.numpychanged the type alias in2.5.0so we need another way to detect it.CI is failing - https://github.com/apache/spark/actions/runs/28064134730/job/83087583742
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Local test passed
Was this patch authored or co-authored using generative AI tooling?
Yes, Claude Code (Opus 4.8 high)